CC Automation - reclaim-space CLI test #14425

sambible · 2024-03-15T18:37:20Z

Test for following BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2164997

Also adds the associated CLI endpoint to enable the test.

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_positive_reclaim_space'

sambible · 2024-03-15T18:50:59Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_positive_reclaim_space'

Griffin-Sullivan

Code looks good to me. Let's rerun PRT. Should this also be tested with a custom repo that does an immediate sync? Not sure exactly what reclaim space does but in this scenario I assume all it would be removing is metadata and not actual packages?

Griffin-Sullivan · 2024-03-18T13:50:40Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_positive_reclaim_space'

vsedmik · 2024-03-18T14:19:52Z

Code looks good to me. Let's rerun PRT. Should this also be tested with a custom repo that does an immediate sync? Not sure exactly what reclaim space does but in this scenario I assume all it would be removing is metadata and not actual packages?

@Griffin-Sullivan Reclaim_space actually applies to the on_demand repos (yes, it could be even custom but on_demand). It purges the downloaded rpms to release the storage but keeps the metadata. For reference see: https://docs.pulpproject.org/pulpcore/workflows/reclaim-disk-space.html

Griffin-Sullivan · 2024-03-18T14:27:06Z

Looks like the actual error is happening when disabling SCA for the entitlement manifest:

Received HTTP 500 response: {"displayMessage":"Content access mode is not present in the content access mode list for this org: entitlement","errors":["Content access mode is not present in the content access mode list for this org: entitlement"]}

Does this need to be an entitlement manifest? If not try with SCA manifest

jyejare

ACK pending question and not-blocking comment !

jyejare · 2024-03-19T07:40:20Z

tests/foreman/cli/test_repositories.py

+        2. hammer repository reclaim-space --id REPOID --organization-id ORGID
+
+
+    :expectedresults: Command works as expected


Should have a better expected result! Something like the space is reclaimed or more descriptive.

Yes, it should state here that the space is really reclaimed and at the end, it should be asserted. The fact this passes without any error doesn't mean it works.

jyejare · 2024-03-19T07:52:11Z

tests/foreman/cli/test_repositories.py

+    )
+    # Checking that the fail message isn't present. On a success, no message is returned
+    if output != {}:
+        assert 'Could not reclaim the repository' not in output[0]['message']


Couldnt we have some real scenario of reclaiming space rather than this generic check ?

I mean where we could verify some bytes/mbs are reclaimed ?

rplevka

my comments are not really blocking

rplevka · 2024-03-19T08:18:34Z

tests/foreman/cli/test_repositories.py

+        releasever=REPOS['kickstart']['rhel8_aps']['version'],
+    )
+    repo = module_target_sat.api.Repository(id=rh_repo_id).read()
+    repo.sync(timeout=600)


I think that all of the steps up until this point should be considered a setup. Consider using the already existing fixtures that prepare the repos for you, e.g. custom_synced_repo and module_repository

rplevka · 2024-03-19T08:25:12Z

tests/foreman/cli/test_repositories.py

@@ -124,3 +124,41 @@ def test_positive_disable_rh_repo_with_basearch(module_target_sat, module_entitl
        }
    )
    assert 'Repository disabled' in disabled_repo[0]['message']
+
+
+def test_positive_reclaim_space(module_target_sat, module_entitlement_manifest_org):


I'd probably change the name so it is not too misleading - I believe you do not really test that any space has been reclaimed, since you only run it on an on-demand-synced repo, right?

lhellebr

I think this should verify that some space is actually reclaimed. Absence of error message doesn't mean it works.

lhellebr · 2024-03-25T15:55:31Z

Related: #14397

sambible · 2024-04-08T16:00:20Z

There's a lot of conversation around here that's valuable, but I'd like to ask if it's reasonable to get keep this test more focused on the actual CLI error that the BZ was originally written against, which is what it tests currently. I've changed the name to be more explicit, so hopefully that makes the purpose of this clear.

devendra104 · 2024-04-08T17:32:32Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_reclaim_space_command_no_exception'

Satellite-QE · 2024-04-08T17:53:16Z

PRT Result

Build Number: 6371
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_repositories.py -k test_reclaim_space_command_no_exception --external-logging
Test Result : ============ 5 deselected, 3 warnings, 1 error in 722.51s (0:12:02) ============

sambible · 2024-04-08T19:51:28Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_reclaim_space_command_no_exception'

Satellite-QE · 2024-04-08T20:10:39Z

PRT Result

Build Number: 6373
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_repositories.py -k test_reclaim_space_command_no_exception --external-logging
Test Result : =========== 1 passed, 5 deselected, 4 warnings in 849.48s (0:14:09) ============

vsedmik

ACK, @sambible can you rebase?

sambible added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 15, 2024

sambible self-assigned this Mar 15, 2024

sambible requested review from a team as code owners March 15, 2024 18:37

sambible force-pushed the reclaim-space branch from 3cc2945 to 4a74c28 Compare March 15, 2024 18:37

Griffin-Sullivan approved these changes Mar 18, 2024

View reviewed changes

jyejare reviewed Mar 19, 2024

View reviewed changes

rplevka approved these changes Mar 19, 2024

View reviewed changes

lhellebr reviewed Mar 25, 2024

View reviewed changes

lhellebr mentioned this pull request Mar 25, 2024

Add test case to trigger the reclaim_space task #14397

Merged

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 8, 2024

Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 8, 2024

sambible force-pushed the reclaim-space branch from 52a604f to 4bb9568 Compare April 8, 2024 19:53

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024

vsedmik approved these changes May 17, 2024

View reviewed changes

pnovotny approved these changes May 31, 2024

View reviewed changes

sambible added 2 commits June 5, 2024 10:28

Add test for reclaim-space bz

ca25aee

Add test for reclaim-space bz

9037d3f

sambible added 3 commits June 5, 2024 10:29

change test name

6e1fc84

Change to non-sca org

9d63c82

change test name

48ec919

sambible force-pushed the reclaim-space branch from 4bb9568 to 5bc05e8 Compare June 5, 2024 15:32

sambible requested a review from a team as a code owner June 5, 2024 15:32

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 5, 2024

Change to non-sca org

756e061

sambible force-pushed the reclaim-space branch from 5bc05e8 to 756e061 Compare June 5, 2024 15:36

vsedmik merged commit ede06b2 into SatelliteQE:master Jun 5, 2024
8 checks passed

This was referenced Jun 5, 2024

[Failed-AutoCherryPick] - CC Automation - reclaim-space CLI test #15330

Open

[Failed-AutoCherryPick] - CC Automation - reclaim-space CLI test #15331

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CC Automation - reclaim-space CLI test #14425

CC Automation - reclaim-space CLI test #14425

sambible commented Mar 15, 2024

sambible commented Mar 15, 2024

Griffin-Sullivan left a comment

Griffin-Sullivan commented Mar 18, 2024

vsedmik commented Mar 18, 2024

Griffin-Sullivan commented Mar 18, 2024

jyejare left a comment

jyejare Mar 19, 2024

lhellebr Mar 25, 2024

jyejare Mar 19, 2024

rplevka left a comment

rplevka Mar 19, 2024

rplevka Mar 19, 2024

lhellebr left a comment

lhellebr commented Mar 25, 2024

sambible commented Apr 8, 2024

devendra104 commented Apr 8, 2024

Satellite-QE commented Apr 8, 2024

sambible commented Apr 8, 2024

Satellite-QE commented Apr 8, 2024

vsedmik left a comment

		2. hammer repository reclaim-space --id REPOID --organization-id ORGID


		:expectedresults: Command works as expected

CC Automation - reclaim-space CLI test #14425

CC Automation - reclaim-space CLI test #14425

Conversation

sambible commented Mar 15, 2024

sambible commented Mar 15, 2024

Griffin-Sullivan left a comment

Choose a reason for hiding this comment

Griffin-Sullivan commented Mar 18, 2024

vsedmik commented Mar 18, 2024

Griffin-Sullivan commented Mar 18, 2024

jyejare left a comment

Choose a reason for hiding this comment

jyejare Mar 19, 2024

Choose a reason for hiding this comment

lhellebr Mar 25, 2024

Choose a reason for hiding this comment

jyejare Mar 19, 2024

Choose a reason for hiding this comment

rplevka left a comment

Choose a reason for hiding this comment

rplevka Mar 19, 2024

Choose a reason for hiding this comment

rplevka Mar 19, 2024

Choose a reason for hiding this comment

lhellebr left a comment

Choose a reason for hiding this comment

lhellebr commented Mar 25, 2024

sambible commented Apr 8, 2024

devendra104 commented Apr 8, 2024

Satellite-QE commented Apr 8, 2024

sambible commented Apr 8, 2024

Satellite-QE commented Apr 8, 2024

vsedmik left a comment

Choose a reason for hiding this comment