Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: new test for notification_recipients endpoint #14592

Merged
merged 1 commit into from
Apr 8, 2024
Merged

notifications: new test for notification_recipients endpoint #14592

merged 1 commit into from
Apr 8, 2024

Conversation

pnovotny
Copy link
Contributor

@pnovotny pnovotny commented Apr 2, 2024

This new test verifies that endpoint /notification_recipients works and returns correct data structure.

It covers bug https://bugzilla.redhat.com/2249970 where this broken endpoint caused some web UI pages to fail to load.

@pnovotny
notifications: new test for notification_recipients endpoint
5167ceb 
This new test verifies that endpoint `/notification_recipients` works
and returns correct data structure.

It covers bug https://bugzilla.redhat.com/2249970
where this broken endpoint caused some web UI pages to fail to load.
@pnovotny pnovotny requested review from lhellebr, pondrejk and a team April 2, 2024 20:10
@pnovotny pnovotny self-assigned this Apr 2, 2024
@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 2, 2024
@pnovotny
Copy link
Contributor Author

pnovotny commented Apr 2, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_positive_notification_recipients

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6276
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_notifications.py -k test_positive_notification_recipients --external-logging
Test Result : =========== 1 failed, 2 deselected, 4 warnings in 708.46s (0:11:48) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 2, 2024
@pnovotny pnovotny mentioned this pull request Apr 2, 2024
Merged
@pnovotny
Copy link
Contributor Author

pnovotny commented Apr 2, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_positive_notification_recipients
nailgun: 1118

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6277
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_notifications.py -k test_positive_notification_recipients --external-logging
Test Result : =========== 1 passed, 2 deselected, 4 warnings in 703.68s (0:11:43) ============

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 2, 2024
@pnovotny pnovotny marked this pull request as ready for review April 2, 2024 21:03
Griffin-Sullivan
Griffin-Sullivan approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Comments are non-blocking

tests/foreman/api/test_notifications.py Show resolved Hide resolved
tests/foreman/api/test_notifications.py Show resolved Hide resolved
@pnovotny
Copy link
Contributor Author

pnovotny commented Apr 4, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_positive_notification_recipients
nailgun: 1118

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6318
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_notifications.py -k test_positive_notification_recipients --external-logging
Test Result : =========== 1 passed, 2 deselected, 4 warnings in 831.24s (0:13:51) ============

ogajduse
ogajduse approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Waiting for at least one ACK from someone from the Endeavour team.

This was referenced Apr 8, 2024
Merged
Merged
@pondrejk pondrejk merged commit 349c75a into SatelliteQE:master Apr 8, 2024
15 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Apr 8, 2024
Closed
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
@pnovotny @web-flow
notifications: new test for notification_recipients endpoint (#14592)
1334ae4 
This new test verifies that endpoint `/notification_recipients` works
and returns correct data structure.

It covers bug https://bugzilla.redhat.com/2249970
where this broken endpoint caused some web UI pages to fail to load.

(cherry picked from commit 349c75a)
@Satellite-QE Satellite-QE mentioned this pull request Apr 8, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Apr 9, 2024
@Satellite-QE @pnovotny
[6.15.z] notifications: new test for notification_recipients endpoint (…
dcabb2d 
…#14663)

notifications: new test for notification_recipients endpoint (#14592)

This new test verifies that endpoint `/notification_recipients` works
and returns correct data structure.

It covers bug https://bugzilla.redhat.com/2249970
where this broken endpoint caused some web UI pages to fail to load.

(cherry picked from commit 349c75a)

Co-authored-by: Pavel Novotny <pnovotny@users.noreply.github.com>
pnovotny added a commit to pnovotny/robottelo that referenced this pull request Apr 9, 2024
@pnovotny
notifications: new test for notification_recipients endpoint (Satelli…
ab3bac9 
…teQE#14592)

This new test verifies that endpoint `/notification_recipients` works
and returns correct data structure.

It covers bug https://bugzilla.redhat.com/2249970
where this broken endpoint caused some web UI pages to fail to load.
This was referenced Apr 9, 2024
Closed
Merged
Griffin-Sullivan pushed a commit that referenced this pull request Apr 9, 2024
@pnovotny
[6.14.z] notifications: new test for notification_recipients endpoint (…
7170370 
…#14698)

notifications: new test for notification_recipients endpoint (#14592)

This new test verifies that endpoint `/notification_recipients` works
and returns correct data structure.

It covers bug https://bugzilla.redhat.com/2249970
where this broken endpoint caused some web UI pages to fail to load.
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pnovotny @shweta83
notifications: new test for notification_recipients endpoint (Satelli…
1b80c57 
…teQE#14592)

This new test verifies that endpoint `/notification_recipients` works
and returns correct data structure.

It covers bug https://bugzilla.redhat.com/2249970
where this broken endpoint caused some web UI pages to fail to load.
@pnovotny pnovotny deleted the notification_recipients branch April 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare left review comments

@pondrejk pondrejk pondrejk approved these changes

@sambible sambible sambible approved these changes

@ogajduse ogajduse ogajduse approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@lhellebr lhellebr Awaiting requested review from lhellebr

Assignees

@pnovotny pnovotny

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pnovotny @Satellite-QE @pondrejk @jyejare @sambible @ogajduse @Griffin-Sullivan