Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test syncplan creation with custom timezone #15120

Merged
merged 1 commit into from
May 23, 2024
Merged

test syncplan creation with custom timezone #15120

merged 1 commit into from
May 23, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

Customer scenario coverage for bz#2015344

Solution

Check if non UTC datetime is processed correctly by hammer

Related Issues

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 21, 2024
@pondrejk pondrejk self-assigned this May 21, 2024
@pondrejk pondrejk requested a review from a team as a code owner May 21, 2024 12:23
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_syncplan.py -k timezone

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7028
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_syncplan.py -k  timezone --external-logging
Test Result : ========== 1 passed, 85 deselected, 94 warnings in 647.11s (0:10:47) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 21, 2024
vsedmik
vsedmik requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change request and a question.

tests/foreman/cli/test_syncplan.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_syncplan.py Show resolved Hide resolved
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 21, 2024
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_syncplan.py -k timezone

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7040
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_syncplan.py -k timezone --external-logging
Test Result : ========== 1 passed, 85 deselected, 94 warnings in 643.59s (0:10:43) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 21, 2024
@vsedmik vsedmik merged commit 27b3e06 into SatelliteQE:master May 23, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 23, 2024
@pondrejk @web-flow
test syncplan creation with custom timezone (#15120)
0e524e4 
(cherry picked from commit 27b3e06)
@Satellite-QE Satellite-QE mentioned this pull request May 23, 2024
Merged
@dosas
Copy link
Collaborator

dosas commented Jun 20, 2024 •
edited
Loading

@pondrejk Looking at this comment I am pretty sure that this test is working by coincidence (probably the default timezone on the CI servers?). Because CEST is not a valid timezone that can be parsed by hammer-cli (It is just ignored). It should be something like +04:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosas dosas dosas left review comments

@vsedmik vsedmik vsedmik approved these changes

@synkd synkd synkd approved these changes

Assignees

@pondrejk pondrejk

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pondrejk @Satellite-QE @dosas @vsedmik @synkd