Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing self #15184

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix missing self #15184

merged 1 commit into from
May 28, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented May 27, 2024

Problem Statement

Fix missing self call forgotten in #14678

Solution

Related Tests

tests/foreman/cli/test_contentview.py::TestContentView::test_positive_update_composite_with_component_ids

@dosas dosas requested a review from a team as a code owner May 27, 2024 10:19
@dosas dosas added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 27, 2024
@omkarkhatavkar
Copy link
Contributor

Can one of the admins verify this patch?

@dosas dosas requested a review from sambible May 27, 2024 12:43
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @dosas !

@vsedmik vsedmik merged commit 379b7a2 into SatelliteQE:master May 28, 2024
9 of 10 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2024
(cherry picked from commit 379b7a2)
github-actions bot pushed a commit that referenced this pull request May 28, 2024
(cherry picked from commit 379b7a2)
vsedmik pushed a commit that referenced this pull request May 28, 2024
Fix missing self (#15184)

(cherry picked from commit 379b7a2)

Co-authored-by: dosas <dosas@users.noreply.github.com>
vsedmik pushed a commit that referenced this pull request May 28, 2024
Fix missing self (#15184)

(cherry picked from commit 379b7a2)

Co-authored-by: dosas <dosas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants