Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Hypervisor host subscription status and hypervisor host and virtual guest mapping in UI #15288

Conversation

yanpliu
Copy link
Contributor

@yanpliu yanpliu commented Jun 4, 2024

Test Cases: PASS

(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_hyperv_sca.py  -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 17 deselected, 11 warnings in 461.63s (0:07:41)
=============================================================================
(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_esx_sca.py  -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 17 deselected, 11 warnings in 461.63s (0:07:41)
2024-06-04 03:49:38 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.
(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_libvirt_sca.py  -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 2 deselected, 11 warnings in 534.11s (0:08:54)
2024-06-04 04:15:38 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.
(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_nutanix_sca.py  -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 6 deselected, 11 warnings in 530.85s (0:08:50)
2024-06-04 04:27:38 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.
(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_kubevirt_sca.py  -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 2 deselected, 11 warnings in 634.01s (0:10:34)
2024-06-04 04:39:01 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.

@yanpliu yanpliu added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z labels Jun 4, 2024
@yanpliu yanpliu self-assigned this Jun 4, 2024
@yanpliu yanpliu requested a review from a team as a code owner June 4, 2024 08:54
@jyejare jyejare removed the 6.16.z label Jun 5, 2024
@yanpliu yanpliu added the 6.14.z Introduced in or relating directly to Satellite 6.14 label Jun 7, 2024
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewisely the changes look good, I just wonder why we copy-paste the code 5-times? Even the previous code of these test cases looks the same. Would it make sense to use some helper or parametrize the test case so that we don't have same test/code in 5 different test modules?

@yanpliu yanpliu requested a review from a team as a code owner June 13, 2024 01:35
@yanpliu
Copy link
Contributor Author

yanpliu commented Jun 13, 2024

Codewisely the changes look good, I just wonder why we copy-paste the code 5-times? Even the previous code of these test cases looks the same. Would it make sense to use some helper or parametrize the test case so that we don't have same test/code in 5 different test modules?

@vsedmik Thank you very much for your suggestions, have already optimized the duplicated code

@yanpliu
Copy link
Contributor Author

yanpliu commented Jun 13, 2024

Codewisely the changes look good, I just wonder why we copy-paste the code 5-times? Even the previous code of these test cases looks the same. Would it make sense to use some helper or parametrize the test case so that we don't have same test/code in 5 different test modules?

@vsedmik Thank you very much for your suggestions, have already optimized the duplicated code

Test Results: PASS


(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_esx_sca.py -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.         
 1 passed, 17 deselected, 11 warnings in 688.48s (0:11:28) 
2024-06-12 05:23:13 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.
(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_hyperv_sca.py -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 2 deselected, 11 warnings in 617.46s (0:10:17)
2024-06-12 20:26:01 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.
(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_libvirt_sca.py -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 2 deselected, 11 warnings in 548.94s (0:09:08)
2024-06-12 20:41:43 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.

(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/ui/test_nutanix_sca.py -k test_positive_deploy_configure_by_id_script[id] --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 6 deselected, 11 warnings in 532.25s (0:08:52)
2024-06-12 21:25:49 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.

@Gauravtalreja1 Gauravtalreja1 merged commit 8fab3b1 into SatelliteQE:master Jun 13, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
…tual guest mapping in UI (#15288)

* Check Hypervisor host subscription status and hypervisor host and virtual guest mapping in UI

* optimize the duplicated code to method

(cherry picked from commit 8fab3b1)
Gauravtalreja1 pushed a commit that referenced this pull request Jun 13, 2024
…t and virtual guest mapping in UI (#15400)

Check Hypervisor host subscription status and hypervisor host and virtual guest mapping in UI (#15288)

* Check Hypervisor host subscription status and hypervisor host and virtual guest mapping in UI

* optimize the duplicated code to method

(cherry picked from commit 8fab3b1)

Co-authored-by: yanpliu <yanpliu@redhat.com>
@yanpliu yanpliu deleted the virt-who-config-ui-status-mapping-check branch June 13, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants