Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip assertion for test_satellite_installation if SAT-21086 is open #15358

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Skip assertion for test_satellite_installation if SAT-21086 is open #15358

merged 1 commit into from
Jun 6, 2024

Conversation

jameerpathan111
Copy link
Contributor

@jameerpathan111 jameerpathan111 commented Jun 6, 2024 •
edited
Loading

Problem Statement

  • test_satellite_installation is failing because we have migrated to Jira and the bz has been closed without actually being fixed/resolved. It's causing is_open function to return false status and we're now running the assertion which fails.

Solution

  • Use SAT-21086 to check the bug status and skip assertion accordingly.

Related Issues

@jameerpathan111 jameerpathan111 added the No-CherryPick PR doesnt need CherryPick to previous branches label Jun 6, 2024
@jameerpathan111 jameerpathan111 self-assigned this Jun 6, 2024
@jameerpathan111 jameerpathan111 requested a review from a team as a code owner June 6, 2024 19:18
@jameerpathan111
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py -k test_satellite_installation

@JacobCallahan JacobCallahan enabled auto-merge (squash) June 6, 2024 19:25
@JacobCallahan JacobCallahan merged commit b33d1d0 into SatelliteQE:master Jun 6, 2024
8 of 9 checks passed
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7317
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/installer/test_installer.py -k test_satellite_installation --external-logging
Test Result : =========== 23 deselected, 33 warnings, 1 error in 844.34s (0:14:04) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 6, 2024
jameerpathan111 added a commit to jameerpathan111/robottelo that referenced this pull request Jun 6, 2024
@jameerpathan111
Skip assertion for test_satellite_installation if SAT-21086 is open (S…
361b27d 
…atelliteQE#15358)
@jameerpathan111 jameerpathan111 mentioned this pull request Jun 6, 2024
Merged
@JacobCallahan JacobCallahan added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 6, 2024
@devendra104
Copy link
Member

@jameerpathan111 It seems the cherry-pick didn't work for the 6.15.z, 6.13.z, Could you please check?

devendra104 pushed a commit that referenced this pull request Jun 7, 2024
@jameerpathan111
[cherry-pick] Skip assertion for test_satellite_installation if SAT-2…
8a88db8 
…1086 is open (#15360)

Skip assertion for test_satellite_installation if SAT-21086 is open (#15358)
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
@jameerpathan111 @web-flow
[cherry-pick] Skip assertion for test_satellite_installation if SAT-2…
d5d107e 
…1086 is open (#15360)

Skip assertion for test_satellite_installation if SAT-21086 is open (#15358)

(cherry picked from commit 8a88db8)
@Satellite-QE Satellite-QE mentioned this pull request Jun 7, 2024
Merged
omkarkhatavkar pushed a commit that referenced this pull request Jun 7, 2024
@Satellite-QE @jameerpathan111
[6.14.z] [cherry-pick] Skip assertion for test_satellite_installation…
1f7ec6e 
… if SAT-21086 is open (#15365)

[cherry-pick] Skip assertion for test_satellite_installation if SAT-21086 is open (#15360)

Skip assertion for test_satellite_installation if SAT-21086 is open (#15358)

(cherry picked from commit 8a88db8)

Co-authored-by: Jameer Pathan <21165044+jameerpathan111@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@jameerpathan111 jameerpathan111

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jameerpathan111 @Satellite-QE @devendra104 @JacobCallahan