Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CV Eval] Test for CV Eval/BZ #15519

Merged
merged 5 commits into from
Jul 11, 2024
Merged

[CV Eval] Test for CV Eval/BZ #15519

merged 5 commits into from
Jul 11, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Jun 26, 2024 •
edited
Loading

Problem Statement

Test Coverage for https://bugzilla.redhat.com/show_bug.cgi?id=2137318/https://issues.redhat.com/browse/SAT-15185

Solution

Added Test + support for content view version purge

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'test_cv_version_purge'

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 26, 2024
@sambible sambible self-assigned this Jun 26, 2024
@sambible sambible requested review from a team as code owners June 26, 2024 18:40
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'test_cv_version_purge'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7545
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py -k test_cv_version_purge --external-logging
Test Result : ========= 1 passed, 116 deselected, 125 warnings in 808.76s (0:13:28) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 26, 2024
vsedmik
vsedmik reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few proposals for improvement, otherwise looks good to me.

robottelo/cli/contentview.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
sambible and others added 2 commits July 1, 2024 07:39
@sambible @vsedmik
Apply suggestions from code review
f5c2748 
Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>
@sambible
Merge branch 'master' into cv-purge
6cf33d9
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 1, 2024
@sambible
Copy link
Contributor Author

sambible commented Jul 3, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'test_cv_version_purge'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7623
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py -k test_cv_version_purge --external-logging
Test Result : ========= 1 passed, 117 deselected, 126 warnings in 949.80s (0:15:49) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 3, 2024
damoore044
damoore044 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack lgtm

LadislavVasina1
LadislavVasina1 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Gauravtalreja1 Gauravtalreja1 merged commit 9e40aa9 into SatelliteQE:master Jul 11, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
@sambible @web-flow
[CV Eval] Test for CV Eval/BZ (#15519)
0eab731 
* Test for CV Eval/BZ

* Apply suggestions from code review

Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>

* Fix docstring

---------

Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>
(cherry picked from commit 9e40aa9)
This was referenced Jul 11, 2024
Open
Merged
vsedmik pushed a commit that referenced this pull request Jul 11, 2024
@Satellite-QE @sambible
[6.15.z] [CV Eval] Test for CV Eval/BZ (#15626)
d3e6bec 
[CV Eval] Test for CV Eval/BZ (#15519)

* Test for CV Eval/BZ

* Apply suggestions from code review

Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>

* Fix docstring

---------

Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>
(cherry picked from commit 9e40aa9)

Co-authored-by: Samuel Bible <sbible@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@damoore044 damoore044 damoore044 approved these changes

Assignees

@sambible sambible

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sambible @Satellite-QE @Gauravtalreja1 @vsedmik @LadislavVasina1 @damoore044