Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove no_proxy default check in /etc/virt-who.conf #15592

Merged
merged 1 commit into from
Jul 11, 2024
Merged

remove no_proxy default check in /etc/virt-who.conf #15592

merged 1 commit into from
Jul 11, 2024

Conversation

yanpliu
Copy link
Contributor

@yanpliu yanpliu commented Jul 9, 2024

Problem Statement

As the default no_proxy is not enabled in /etc/virt-who.conf , if the no_proxy is not set, it will also not enable in /etc/virt-who.conf , so remove the default check
[system_environment]
#http_proxy=
#https_proxy=
#no_proxy=

Test Cases: PASS

(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/api/test_esx_sca.py -k test_positive_proxy_option --disable-pytest-warnings -q
.                                                                                                                                                                                                           [100%]
1 passed, 12 deselected, 3 warnings in 174.34s (0:02:54)

@yanpliu yanpliu added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 9, 2024
@yanpliu yanpliu self-assigned this Jul 9, 2024
@yanpliu yanpliu requested a review from a team as a code owner July 9, 2024 03:01
@vsedmik vsedmik merged commit 3e5af08 into SatelliteQE:master Jul 11, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
@yanpliu @web-flow
remove no_proxy default check in /etc/virt-who.conf (#15592)
354e985 
(cherry picked from commit 3e5af08)
@Satellite-QE Satellite-QE mentioned this pull request Jul 11, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
@yanpliu @web-flow
remove no_proxy default check in /etc/virt-who.conf (#15592)
575b8a5 
(cherry picked from commit 3e5af08)
@Satellite-QE Satellite-QE mentioned this pull request Jul 11, 2024
Merged
@yanpliu yanpliu deleted the virtwho_http_Proxy branch July 12, 2024 02:01
Gauravtalreja1 pushed a commit that referenced this pull request Jul 12, 2024
@Satellite-QE @yanpliu
[6.15.z] remove no_proxy default check in /etc/virt-who.conf (#15627)
690e60a 
remove no_proxy default check in /etc/virt-who.conf (#15592)

(cherry picked from commit 3e5af08)

Co-authored-by: yanpliu <yanpliu@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 12, 2024
@Satellite-QE @yanpliu
[6.14.z] remove no_proxy default check in /etc/virt-who.conf (#15628)
5641b14 
remove no_proxy default check in /etc/virt-who.conf (#15592)

(cherry picked from commit 3e5af08)

Co-authored-by: yanpliu <yanpliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@synkd synkd synkd approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@yanpliu yanpliu

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanpliu @vsedmik @synkd @LadislavVasina1