fix in hosts param crud test

[pondrejk]

Problem Statement

assertion error

Solution

reacting to change in param object

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_parameter_crud

[Satellite-QE]

PRT Result

Build Number: 7672
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_parameter_crud --external-logging
Test Result : ================== 1 passed, 9 warnings in 668.81s (0:11:08) ===================

[vijaysawant]

Why we are changing the older way of assertion? what is return value of host['parameters'] ?
I would assert with exact name & value rather asserting with list type object.

assert name == host['parameters']['name']
assert value == host['parameters']['value']

[vijaysawant]

If we are going to continue with these new changes then I would suggest to use single quote for string to maintain consistant pattern

Suggested change

	assert name in [param["name"] for param in host['parameters']]
	assert value in [param["value"] for param in host['parameters']]
	assert name in [param['name'] for param in host['parameters']]
	assert value in [param['value'] for param in host['parameters']]

[shweta83]

Can we merge these assertions like "(name,value) in [(param['name'], param['value']) for param in host['parameters']]"

[vijaysawant]

Suggested change

	assert name in [param["name"] for param in host['parameters']]
	assert new_value in [param["value"] for param in host['parameters']]
	assert name in [param['name'] for param in host['parameters']]
	assert new_value in [param['value'] for param in host['parameters']]

[vijaysawant]

Suggested change

	assert name not in [param["name"] for param in host['parameters']]
	assert name not in [param['name'] for param in host['parameters']]

[shweta83]

Can we merge these assertions like "(name,value) in [(param['name'], param['value']) for param in host['parameters']]"

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_parameter_crud

[pondrejk]

Why we are changing the older way of assertion? what is return value of host['parameters'] ? I would assert with exact name & value rather asserting with list type object.

assert name == host['parameters']['name']
assert value == host['parameters']['value']
`, 

host['parameters'] is a list of dictionaries, something like [{name: 'a', value:'b'}]

[Satellite-QE]

PRT Result

Build Number: 7692
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_parameter_crud --external-logging
Test Result : ================== 1 passed, 9 warnings in 645.04s (0:10:45) ===================

[vijaysawant]

Why we are changing the older way of assertion? what is return value of host['parameters'] ? I would assert with exact name & value rather asserting with list type object.

assert name == host['parameters']['name']
assert value == host['parameters']['value']
`, 

host['parameters'] is a list of dictionaries, something like [{name: 'a', value:'b'}]

we can do something like this, can you please check and update?

for key, value in host['parameters'].items():
    assert (name, value) == (key, value)

This can be done in other better way

[vijaysawant]

Thanks for work @pondrejk
Ack

[shweta83]

Ack.

[pondrejk]

we can do something like this, can you please check and update?

for key, value in host['parameters'].items():
    assert (name, value) == (key, value)

This can be done in other better way

I think that would only work with a single parameter assigned to a host, since we use function host I suppose there could be more params