Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container tags related failures #15598

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix container tags related failures #15598

merged 1 commit into from
Jul 10, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jul 9, 2024 •
edited
Loading

Problem Statement

  1. Name for container image tags was unified with API some time ago but we haven't update our tests.
  2. The container-image-tags-filter has been deprecated and is not printed by hammer. It will be replaced win included-tags and excluded-tags.

Solution

This PR fixes 1. and skips 2. until the bugjira is closed

Related issues

https://issues.redhat.com/browse/SAT-26322

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_docker.py::TestDockerRepository::test_positive_sync tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_additive tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_content_only tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_mix_valid_invalid_tags tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_invalid_tags

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 9, 2024
@vsedmik vsedmik self-assigned this Jul 9, 2024
@vsedmik vsedmik requested a review from a team as a code owner July 9, 2024 10:26
@vsedmik
Copy link
Contributor Author

vsedmik commented Jul 9, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_docker.py::TestDockerRepository::test_positive_sync tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_additive tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_content_only tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_mix_valid_invalid_tags tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_invalid_tags

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7675
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_docker.py::TestDockerRepository::test_positive_sync tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_additive tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_content_only tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_mix_valid_invalid_tags tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_invalid_tags --external-logging
Test Result : ================== 5 passed, 47 warnings in 899.49s (0:14:59) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 9, 2024
pondrejk
pondrejk requested changes Jul 9, 2024
View reviewed changes
tests/foreman/cli/test_repository.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_repository.py Outdated Show resolved Hide resolved
damoore044
damoore044 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack pending discussion above

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 9, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Jul 9, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_docker.py::TestDockerRepository::test_positive_sync tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_additive tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_content_only tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_mix_valid_invalid_tags tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_invalid_tags

@vsedmik vsedmik requested a review from pondrejk July 9, 2024 17:47
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7685
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_docker.py::TestDockerRepository::test_positive_sync tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_additive tests/foreman/cli/test_repository.py::TestRepository::test_positive_synchronize_docker_repo_set_tags_later_content_only tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_mix_valid_invalid_tags tests/foreman/cli/test_repository.py::TestRepository::test_negative_synchronize_docker_repo_with_invalid_tags --external-logging
Test Result : ================== 5 passed, 59 warnings in 979.01s (0:16:19) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 9, 2024
LadislavVasina1
LadislavVasina1 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, looks good to me

@pondrejk pondrejk merged commit 8a10158 into SatelliteQE:master Jul 10, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
@vsedmik @web-flow
Fix container tags related failures (#15598)
1107082 
(cherry picked from commit 8a10158)
@Satellite-QE Satellite-QE mentioned this pull request Jul 10, 2024
Merged
vsedmik added a commit that referenced this pull request Jul 10, 2024
@Satellite-QE @vsedmik
[6.15.z] Fix container tags related failures (#15620)
9e78b60 
Fix container tags related failures (#15598)

(cherry picked from commit 8a10158)

Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@damoore044 damoore044 damoore044 approved these changes

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vsedmik @Satellite-QE @pondrejk @LadislavVasina1 @damoore044