Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Comp Eval] Removing Duplicate Test From Upgrades #15731

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[Comp Eval] Removing Duplicate Test From Upgrades #15731

merged 3 commits into from
Jul 24, 2024

Conversation

ColeHiggins2
Copy link
Member

Removing a duplicate test as part of the upgrades comp eval

@ColeHiggins2 ColeHiggins2 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 22, 2024
@ColeHiggins2 ColeHiggins2 self-assigned this Jul 22, 2024
@ColeHiggins2 ColeHiggins2 requested a review from a team as a code owner July 22, 2024 18:17
@ColeHiggins2
Copy link
Member Author

Open to adding labels to cherrypick into previous versions

@ColeHiggins2 ColeHiggins2 added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Jul 22, 2024
@jameerpathan111
Copy link
Contributor

jameerpathan111 commented Jul 23, 2024 •
edited
Loading

Removing a duplicate test as part of the upgrades comp eval

@ColeHiggins2 test_positive_synchronize_custom_product_weekly_recurrence is this the duplicate test you're talking about? If yes, should we merge them and make one parameterized test instead?

@jameerpathan111 jameerpathan111 self-requested a review July 23, 2024 08:38
sambible
sambible approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is duplicated in CLI and API testing, and that's not necessary for coverage, so it's being removed. LGTM

@jameerpathan111
Copy link
Contributor

jameerpathan111 commented Jul 24, 2024 •
edited
Loading

This test is duplicated in CLI and API testing, and that's not necessary for coverage, so it's being removed. LGTM

If that's the case, wouldn't keeping the CLI test and removing the API one be better?
Note: non-blocking comment, feel free to merge the PR.

@Gauravtalreja1 Gauravtalreja1 merged commit 2e4f285 into SatelliteQE:master Jul 24, 2024
14 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@ColeHiggins2 @web-flow
[Comp Eval] Removing Duplicate Test From Upgrades (#15731)
b34ea0c 
* Adding pit marker for tests

* Removing dupe test case

* removing extra commit

(cherry picked from commit 2e4f285)
@Satellite-QE Satellite-QE mentioned this pull request Jul 24, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@ColeHiggins2 @web-flow
[Comp Eval] Removing Duplicate Test From Upgrades (#15731)
8bc8216 
* Adding pit marker for tests

* Removing dupe test case

* removing extra commit

(cherry picked from commit 2e4f285)
@Satellite-QE Satellite-QE mentioned this pull request Jul 24, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@ColeHiggins2 @web-flow
[Comp Eval] Removing Duplicate Test From Upgrades (#15731)
6684534 
* Adding pit marker for tests

* Removing dupe test case

* removing extra commit

(cherry picked from commit 2e4f285)
@Satellite-QE Satellite-QE mentioned this pull request Jul 24, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Jul 24, 2024
@Satellite-QE @ColeHiggins2
[6.15.z] [Comp Eval] Removing Duplicate Test From Upgrades (#15747)
2707743 
[Comp Eval] Removing Duplicate Test From Upgrades (#15731)

* Adding pit marker for tests

* Removing dupe test case

* removing extra commit

(cherry picked from commit 2e4f285)

Co-authored-by: Cole Higgins <chiggins@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 24, 2024
@Satellite-QE @ColeHiggins2
[6.14.z] [Comp Eval] Removing Duplicate Test From Upgrades (#15746)
48439cf 
[Comp Eval] Removing Duplicate Test From Upgrades (#15731)

* Adding pit marker for tests

* Removing dupe test case

* removing extra commit

(cherry picked from commit 2e4f285)

Co-authored-by: Cole Higgins <chiggins@redhat.com>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 24, 2024
@Satellite-QE @ColeHiggins2
[6.13.z] [Comp Eval] Removing Duplicate Test From Upgrades (#15748)
f641bd1 
[Comp Eval] Removing Duplicate Test From Upgrades (#15731)

* Adding pit marker for tests

* Removing dupe test case

* removing extra commit

(cherry picked from commit 2e4f285)

Co-authored-by: Cole Higgins <chiggins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambible sambible sambible approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@damoore044 damoore044 damoore044 approved these changes

Assignees

@ColeHiggins2 ColeHiggins2

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ColeHiggins2 @jameerpathan111 @sambible @Gauravtalreja1 @LadislavVasina1 @damoore044