Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test a case for chhunked ISS import #15734

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add test a case for chhunked ISS import #15734

merged 1 commit into from
Jul 24, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jul 23, 2024 •
edited
Loading

Problem Statement

There is a customer facing bug which needs coverage, see the Related Issues.

Solution

This PR adds it.

Related Issues

https://issues.redhat.com/browse/SAT-23573
https://issues.redhat.com/browse/SAT-26458

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k chunk

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 23, 2024
@vsedmik vsedmik self-assigned this Jul 23, 2024
@vsedmik vsedmik requested a review from a team as a code owner July 23, 2024 14:16
@vsedmik
Copy link
Contributor Author

vsedmik commented Jul 23, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k chunk

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7819
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_satellitesync.py -k chunk --external-logging
Test Result : ========== 1 passed, 34 deselected, 43 warnings in 647.00s (0:10:47) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 23, 2024
sambible
sambible approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small docstring suggestion aside, LGTM

tests/foreman/cli/test_satellitesync.py Outdated Show resolved Hide resolved
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 23, 2024
LadislavVasina1
LadislavVasina1 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@pondrejk pondrejk merged commit 74e9a2d into SatelliteQE:master Jul 24, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@vsedmik @web-flow
Add test a case for chhunked ISS import (#15734)
0ec27a9 
(cherry picked from commit 74e9a2d)
@Satellite-QE Satellite-QE mentioned this pull request Jul 24, 2024
Merged
vsedmik added a commit that referenced this pull request Jul 24, 2024
@Satellite-QE @vsedmik
[6.15.z] Add test a case for chhunked ISS import (#15741)
109556b 
Add test a case for chhunked ISS import (#15734)

(cherry picked from commit 74e9a2d)

Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@sambible sambible sambible approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vsedmik @Satellite-QE @pondrejk @sambible @LadislavVasina1