-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate BZ 1379006 #4231
Automate BZ 1379006 #4231
Conversation
@svtkachenko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalakh, @sthirugn and @oshtaier to be potential reviewers. |
ACK |
Why did commit to master depends on two cherry picks into 6.2.z? |
@oshtaier Sorry, it was a typo, this PR depends on SatelliteQE/nailgun#365 and SatelliteQE/nailgun#366. I've also updated initial description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending question
@BZ: 1379006 | ||
""" | ||
template = entities.ProvisioningTemplate(snippet=False) | ||
template.template_kind_name = gen_string('alpha') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what happens in case of correct template_kind_name (but no id specified)? Can't see this case covered here. If it doesn't work with correct name passed - then basically this test makes no sense as functionality only works with id (which i guess would be a bug which needs to be resolved).
Added another test witch correct template_kind name. % pytest tests/foreman/api/test_template.py -k 'template_kind'
===================================================================== test session starts =====================================================================
platform linux2 -- Python 2.7.12, pytest-3.0.4, py-1.4.31, pluggy-0.4.0
rootdir: /home/qui/code/robottelo, inifile:
plugins: xdist-1.15.0, html-1.12.0, cov-2.4.0
collected 11 items
tests/foreman/api/test_template.py ...
===================================================================== 8 tests deselected ======================================================================
=========================================================== 3 passed, 8 deselected in 6.24 seconds ============================================================ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
https://bugzilla.redhat.com/show_bug.cgi?id=1379006
Depens on SatelliteQE/nailgun#365 and SatelliteQE/nailgun#366