Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate BZ 1379006 #4231

Merged
merged 2 commits into from
Jan 25, 2017
Merged

Automate BZ 1379006 #4231

merged 2 commits into from
Jan 25, 2017

Conversation

svtkachenko
Copy link
Contributor

@svtkachenko svtkachenko commented Jan 24, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1379006
Depens on SatelliteQE/nailgun#365 and SatelliteQE/nailgun#366

% pytest -v -n 2 tests/foreman/api/test_template.py -k 'template_kind'
===================================================================== test session starts =====================================================================
platform linux2 -- Python 2.7.12, pytest-3.0.4, py-1.4.31, pluggy-0.4.0 -- /home/qui/code/venv/2/bin/python2
cachedir: .cache
rootdir: /home/qui/code/robottelo, inifile: 
plugins: xdist-1.15.0, html-1.12.0, cov-2.4.0
[gw0] linux2 Python 2.7.12 cwd: /home/qui/code/robottelo
[gw1] linux2 Python 2.7.12 cwd: /home/qui/code/robottelo
[gw0] Python 2.7.12 (default, Nov  7 2016, 11:55:55)  -- [GCC 6.2.1 20160830]
[gw1] Python 2.7.12 (default, Nov  7 2016, 11:55:55)  -- [GCC 6.2.1 20160830]
gw0 [2] / gw1 [2]
scheduling tests via LoadScheduling

[gw0] PASSED tests/foreman/api/test_template.py::ConfigTemplateTestCase::test_negative_create_with_template_kind_name 
[gw1] PASSED tests/foreman/api/test_template.py::ConfigTemplateTestCase::test_positive_create_with_template_kind 

================================================================== 2 passed in 6.16 seconds ===================================================================

@svtkachenko svtkachenko added 6.3 API Issues and PRs involving the API labels Jan 24, 2017
@svtkachenko svtkachenko self-assigned this Jan 24, 2017
@mention-bot
Copy link

@svtkachenko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalakh, @sthirugn and @oshtaier to be potential reviewers.

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage remained the same at 71.94% when pulling 471650d on svtkachenko:bz_1379006 into 1b39133 on SatelliteQE:master.

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage remained the same at 71.94% when pulling 471650d on svtkachenko:bz_1379006 into 1b39133 on SatelliteQE:master.

@oshtaier
Copy link
Contributor

ACK

@oshtaier
Copy link
Contributor

Why did commit to master depends on two cherry picks into 6.2.z?

@svtkachenko
Copy link
Contributor Author

svtkachenko commented Jan 25, 2017

@oshtaier Sorry, it was a typo, this PR depends on SatelliteQE/nailgun#365 and SatelliteQE/nailgun#366. I've also updated initial description.

Copy link
Contributor

@abalakh abalakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending question

@BZ: 1379006
"""
template = entities.ProvisioningTemplate(snippet=False)
template.template_kind_name = gen_string('alpha')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what happens in case of correct template_kind_name (but no id specified)? Can't see this case covered here. If it doesn't work with correct name passed - then basically this test makes no sense as functionality only works with id (which i guess would be a bug which needs to be resolved).

@svtkachenko
Copy link
Contributor Author

svtkachenko commented Jan 25, 2017

Added another test witch correct template_kind name.

% pytest tests/foreman/api/test_template.py -k 'template_kind'
===================================================================== test session starts =====================================================================
platform linux2 -- Python 2.7.12, pytest-3.0.4, py-1.4.31, pluggy-0.4.0
rootdir: /home/qui/code/robottelo, inifile: 
plugins: xdist-1.15.0, html-1.12.0, cov-2.4.0
collected 11 items 

tests/foreman/api/test_template.py ...

===================================================================== 8 tests deselected ======================================================================
=========================================================== 3 passed, 8 deselected in 6.24 seconds ============================================================

Copy link
Contributor

@abalakh abalakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@coveralls
Copy link

coveralls commented Jan 25, 2017

Coverage Status

Coverage remained the same at 71.94% when pulling 03ed7c8 on svtkachenko:bz_1379006 into 1b39133 on SatelliteQE:master.

@abalakh abalakh merged commit e04b935 into SatelliteQE:master Jan 25, 2017
@abalakh abalakh removed the review label Jan 25, 2017
@svtkachenko svtkachenko deleted the bz_1379006 branch February 22, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues and PRs involving the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants