Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unskip backup online incremental test #4649

Merged
merged 1 commit into from
May 9, 2017
Merged

unskip backup online incremental test #4649

merged 1 commit into from
May 9, 2017

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented May 5, 2017

This skip had wrong bz number attached, retesting shows it is no longer necessary:

nosetests -v tests/foreman/sys/test_hot_backup.py:HotBackupTestCase.test_positive_online_incremental
Make an incremental online backup ... ok

----------------------------------------------------------------------
Ran 1 test in 674.902s

OK

@mention-bot
Copy link

@pondrejk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pgagne and @rochacbruno to be potential reviewers.

@pondrejk pondrejk added the review label May 5, 2017
@pondrejk pondrejk changed the title unskip online incremental test unskip backup online incremental test May 5, 2017
@pondrejk pondrejk self-assigned this May 5, 2017
@coveralls
Copy link

coveralls commented May 5, 2017 •
edited

Coverage Status

Coverage remained the same at 40.299% when pulling 74f670d on pondrejk:backup-removed-unnecessary-skip-master into 6a63d9a on SatelliteQE:master.

@renzon
Copy link
Contributor

renzon commented May 8, 2017

@pondrejk could you add the BZ id on @bz token on docstring? This way we keep a reference for it so we can search latter. Besides that, ACK

rochacbruno
rochacbruno approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
(pending @renzon comment)

@pondrejk pondrejk force-pushed the backup-removed-unnecessary-skip-master branch from 74f670d to 1656caf Compare May 9, 2017 10:36
@pondrejk pondrejk force-pushed the backup-removed-unnecessary-skip-master branch from 1656caf to 81e2482 Compare May 9, 2017 10:40
@pondrejk
Copy link
Contributor Author

pondrejk commented May 9, 2017

@renzon, I think the correct bz should have been 1445871, updated the docstring accordingly. Cheers

renzon
renzon approved these changes May 9, 2017
View reviewed changes
Copy link
Contributor

@renzon renzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@renzon renzon merged commit 5844852 into SatelliteQE:master May 9, 2017
@renzon renzon removed the review label May 9, 2017
@coveralls
Copy link

coveralls commented May 10, 2017 •
edited

Coverage Status

Coverage remained the same at 40.299% when pulling 81e2482 on pondrejk:backup-removed-unnecessary-skip-master into 29c99ba on SatelliteQE:master.

@coveralls
Copy link

coveralls commented May 10, 2017 •
edited

Coverage Status

Coverage remained the same at 40.299% when pulling 81e2482 on pondrejk:backup-removed-unnecessary-skip-master into 29c99ba on SatelliteQE:master.

@pondrejk pondrejk deleted the backup-removed-unnecessary-skip-master branch May 29, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

@renzon renzon renzon approved these changes

Assignees

@pondrejk pondrejk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pondrejk @mention-bot @coveralls @renzon @rochacbruno