Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Bulk Host Delete action (BZ1368026) #4658

Merged
merged 1 commit into from
May 10, 2017
Merged

Test Bulk Host Delete action (BZ1368026) #4658

merged 1 commit into from
May 10, 2017

Conversation

oshtaier
Copy link
Contributor

@oshtaier oshtaier commented May 9, 2017 

nosetests tests/foreman/ui/test_host.py -m test_positive_bulk
S.
----------------------------------------------------------------------
Ran 2 tests in 226.866s

OK (SKIP=1)

@oshtaier oshtaier added 6.2 QETestCoverage Issues and PRs relating to a Satellite bug UI Issues and PRs involving the UI labels May 9, 2017
@oshtaier oshtaier self-assigned this May 9, 2017
@oshtaier oshtaier added the review label May 9, 2017
ldjebran
ldjebran reviewed May 10, 2017
View reviewed changes
robottelo/ui/hosts.py
self.click(locators['host.bulk_submit'])
return self.wait_until_element(
locators['task.finished_state'],
timeout=parameter['timeout'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should use a default value like so we can omit every time putting the timeout value: timeout=parameter.get('timeout' , 300)
what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the other side if there is no parameter list the action will not execute, so let it as is (is the best option)

ldjebran
ldjebran approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@ldjebran ldjebran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@coveralls
Copy link

coveralls commented May 10, 2017 •
edited

Coverage Status

Coverage increased (+0.07%) to 40.354% when pulling e3ea0ee on oshtaier:bulk_hosts into 32b8692 on SatelliteQE:6.2.z.

renzon
renzon approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@renzon renzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@renzon renzon merged commit 44efd8a into SatelliteQE:6.2.z May 10, 2017
@renzon renzon removed the review label May 10, 2017
@oshtaier oshtaier deleted the bulk_hosts branch May 22, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldjebran ldjebran ldjebran approved these changes

@renzon renzon renzon approved these changes

Assignees

@oshtaier oshtaier

Labels
QETestCoverage Issues and PRs relating to a Satellite bug UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oshtaier @coveralls @ldjebran @renzon