Converted constants using pulp fixtures in fedorapeople to fixtures.pulpproject #7852

Griffin-Sullivan · 2020-06-24T20:10:17Z

With the update to fixtures.pulpproject.org, the depracated SRPM and DRPM repos from fedorapeople needed to be updated. Both repos now use the srpm-signed and drpm-signed endpoints in fixtures.pulpproject.org. The large_errata used in the FAKE_7_YUM_REPO in constants.py will now rely on https://fixtures.pulpproject.org/rpm-long-updateinfo/. Along with these changes, the CUSTOM_RPM_REPO, FAKE_YUM_SRPM_DUPLICATE_REPO, CUSTOM_RPM_SHA_512, and FAKE_0_YUM_REPO_STRING_BASED_VERSIONS repos will now be using fixtures.pulpproject.

============================ test session starts ==============================
platform linux -- Python 3.8.3, pytest-4.6.9, py-1.8.0, pluggy-0.13.0
shared_function enabled - OFF - scope: - storage: file
rootdir: /home/gsulliva/Programming/robottelo
plugins: mock-1.10.4, services-1.3.1, forked-1.1.3, xdist-1.32.0, cov-2.9.0
collecting ... 2020-06-24 19:38:12 - conftest - DEBUG - Collected 12 test cases
collected 12 items

cli/test_repository.py ...sss [ 50%]
api/test_repository.py .sss.. [100%]

=================== 6 passed, 6 skipped in 311.38 seconds ========================

============================= test session starts ==============================
platform linux -- Python 3.8.3, pytest-4.6.9, py-1.8.0, pluggy-0.13.0
shared_function enabled - OFF - scope: - storage: file
rootdir: /home/gsulliva/Programming/robottelo
plugins: mock-1.10.4, services-1.3.1, forked-1.1.3, xdist-1.32.0, cov-2.9.0
collecting ... 2020-06-30 13:02:28 - conftest - DEBUG - Collected 1 test cases
collected 1 item

test_contentmanagement.py . [100%]

========================== 1 passed in 119.64 seconds ==========================

============================== test session starts =============================
platform linux -- Python 3.8.3, pytest-4.6.9, py-1.8.0, pluggy-0.13.0
shared_function enabled - OFF - scope: - storage: file
rootdir: /home/gsulliva/Programming/robottelo
plugins: mock-1.10.4, services-1.3.1, forked-1.1.3, xdist-1.32.0, cov-2.9.0
collecting ... 2020-07-02 18:43:30 - conftest - DEBUG - Collected 6 test cases
collected 6 items

api/test_repository.py . [ 16%]
api/test_contentview.py . [ 33%]
api/test_repository.py .. [ 66%]
endtoend/test_api_endtoend.py . [ 83%]
endtoend/test_cli_endtoend.py . [100%]

========================== 6 passed in 936.83 seconds ==========================

codecov · 2020-06-24T20:19:04Z

Codecov Report

Merging #7852 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7852   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          31       31           
  Lines        4016     4016           
=======================================
  Hits         2693     2693           
  Misses       1323     1323

Impacted Files	Coverage Δ
robottelo/constants.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b01816...0efcf28. Read the comment docs.

swadeley · 2020-06-25T08:20:48Z

tests/foreman/api/test_contentmanagement.py

@@ -72,6 +73,7 @@ class ContentManagementTestCase(APITestCase):
    """

    @tier2
+    @pytest.mark.skip("Uses old large_errata repo from repos.fedorapeople")


Hello @Griffin-Sullivan, first a minor point: your initial comment only mentions SRPM and DRPM repos. You should mention why you are making this change. More important, as this test is for the "ContentManagement" component we should ensure @latran knows about this change (He is primary owner of "Content Management" tests).

@swadeley @Griffin-Sullivan has this been resolved?

@JacobCallahan I updated the commit message, and I'm waiting for @latran to look everything over. I'm working on changing this line altogether, as we will use the https://fixtures.pulpproject.org/rpm-long-updateinfo/ repo to replace large_errata.

@Griffin-Sullivan - content management is disabled/discontinued since February. I plan on either deleting the entirety of test_contentmanagement.py and moving the test cases to the specific component area where it suits the test cases. I'm fine with the overall changes for the time being and we can merge. I'll just have to move the test cases either by myself or work with you on that later.

swadeley

ACK

but I see two changes at least (CUSTOM_FILE_REPO and import pytest) are also in:
Update robottelo to use fixtures.pulpproject.org #7849

You will need to rebase the one when the other is approved.
EDIT: sorry, the github system will check for conflicts, if no conflicts, then no need rebase
EDIT: The skip decorator above test_positive_sync_repos_with_large_errata is also in the earlier PR.

omkarkhatavkar

ACK

daviddavis · 2020-06-26T18:55:25Z

This looks great. Do you need me to look into moving https://repos.fedorapeople.org/pulp/pulp/demo_repos/large_errata/zoo/ over to fixtures.pulpproject.org?

Griffin-Sullivan · 2020-06-26T20:17:27Z

Yes, @daviddavis that would be very helpful!

daviddavis · 2020-06-29T17:31:51Z

@Griffin-Sullivan it looks like the test_positive_sync_repos_with_large_errata test is only testing that katello is able to sync repos with lots of errata. I think you could probably use https://fixtures.pulpproject.org/rpm-long-updateinfo/ instead.

Griffin-Sullivan · 2020-06-29T18:07:28Z

@daviddavis Ok I will try that out and make a new PR if all goes well.

Changed the CUSTOM_FILE_REPO constant to use fixtures.pulpproject and skipped all tests affected by DRPM, SRPM, and FAKE_7_YUM_REPO. New DRPM, SRPM, and FAKE_7_YUM_REPO will need to be created manually and ran locally.

…ulpproject With the update to fixtures.pulpproject.org, the depracated SRPM and DRPM repos from fedorapeople needed to be updated. Both repos now use the srpm-signed and drpm-signed endpoints in fixtures.pulpproject.org. The large_errata used in the FAKE_7_YUM_REPO in constants.py will now rely on https://fixtures.pulpproject.org/rpm-long-updateinfo/. Along with these changes, the CUSTOM_RPM_REPO, FAKE_YUM_SRPM_DUPLICATE_REPO, CUSTOM_RPM_SHA_512, and FAKE_0_YUM_REPO_STRING_BASED_VERSIONS repos will now be using fixtures.pulpproject. ============================ test session starts ============================= platform linux -- Python 3.8.3, pytest-4.6.9, py-1.8.0, pluggy-0.13.0 shared_function enabled - OFF - scope: - storage: file rootdir: /home/gsulliva/Programming/robottelo plugins: mock-1.10.4, services-1.3.1, forked-1.1.3, xdist-1.32.0, cov-2.9.0 collecting ... 2020-06-24 19:38:12 - conftest - DEBUG - Collected 12 test cases collected 12 items cli/test_repository.py ...sss [ 50%] api/test_repository.py .sss.. [100%] =================== 6 passed, 6 skipped in 311.38 seconds ==================== ============================= test session starts ============================== platform linux -- Python 3.8.3, pytest-4.6.9, py-1.8.0, pluggy-0.13.0 shared_function enabled - OFF - scope: - storage: file rootdir: /home/gsulliva/Programming/robottelo plugins: mock-1.10.4, services-1.3.1, forked-1.1.3, xdist-1.32.0, cov-2.9.0 collecting ... 2020-06-30 13:02:28 - conftest - DEBUG - Collected 1 test cases collected 1 item test_contentmanagement.py . [100%] ========================== 1 passed in 119.64 seconds ========================== ============================== test session starts ============================= platform linux -- Python 3.8.3, pytest-4.6.9, py-1.8.0, pluggy-0.13.0 shared_function enabled - OFF - scope: - storage: file rootdir: /home/gsulliva/Programming/robottelo plugins: mock-1.10.4, services-1.3.1, forked-1.1.3, xdist-1.32.0, cov-2.9.0 collecting ... 2020-07-02 18:43:30 - conftest - DEBUG - Collected 6 test cases collected 6 items api/test_repository.py . [ 16%] api/test_contentview.py . [ 33%] api/test_repository.py .. [ 66%] endtoend/test_api_endtoend.py . [ 83%] endtoend/test_cli_endtoend.py . [100%] ========================== 6 passed in 936.83 seconds ==========================

Griffin-Sullivan · 2020-07-06T13:36:16Z

@JacobCallahan @latran @omkarkhatavkar @swadeley Can you all take another look at this? There were 4 additional repos that needed to be changed to fixtures.pulpproject. I've updated the description and title to give more information about these changes.

swadeley · 2020-07-06T13:42:02Z

@Griffin-Sullivan , can you search for a test that has the additional repos you just added and then run that test? Or perhaps the tests you ran before also cover those additional repos? If so, just run them again.

Thank you

Griffin-Sullivan · 2020-07-06T13:44:49Z

@swadeley the "6 passed in 936.83 seconds" in the description are the tests that are affected by the new constants I added to this PR. Should I run those again and the tests I did before?

latran · 2020-07-06T13:48:48Z

@Griffin-Sullivan, you can add the test_contentmanagement.py back in as part of this PR.

Griffin-Sullivan · 2020-07-06T13:52:53Z

@latran I'm pretty sure the constant that affected test_contentmanagement.py is still a part of this PR. The specific repo was FAKE_7_YUM_REPO

swadeley · 2020-07-06T14:04:47Z

@swadeley the "6 passed in 936.83 seconds" in the description are the tests that are affected by the new constants I added to this PR. Should I run those again and the tests I did before?

that would be best, to run them all again, because its not easy for the reviewers to be sure what changed since you ran them last.

swadeley · 2020-07-06T14:05:51Z

@latran I'm pretty sure the constant that affected test_contentmanagement.py is still a part of this PR. The specific repo was FAKE_7_YUM_REPO

I only see robottelo/constants.py under the "Files changed" tab.

Edit: but in the commits I can see it, strange. On your system, do you still have two commits in your branch called Griffin-Sullivan:drpm-srpm ?

Griffin-Sullivan · 2020-07-06T14:08:53Z

@swadeley Ok I'll run them all again. Also the only thing that ever affected test_contentmanagement.py was the FAKE_7_YUM_REPO in constants.py. I never made any changes to the actual test_contentmanagement.py file.

daviddavis · 2020-07-07T12:07:25Z

This looks good to me although I'd probably squash the two commits together.

JacobCallahan

ACK

swadeley reviewed Jun 25, 2020

View reviewed changes

swadeley approved these changes Jun 25, 2020

View reviewed changes

swadeley mentioned this pull request Jun 25, 2020

Update robottelo to use fixtures.pulpproject.org #7849

Merged

omkarkhatavkar approved these changes Jun 26, 2020

View reviewed changes

Griffin-Sullivan force-pushed the drpm-srpm branch from 9f26c0b to 81d228f Compare June 30, 2020 15:56

Griffin-Sullivan changed the title ~~Switched SRPM and DRPM repos to pulpproject~~ Switched SRPM, DRPM, and large_errata repos to pulpproject Jul 1, 2020

Griffin-Sullivan added 2 commits July 6, 2020 09:30

Update robottelo to use fixtures.pulpproject.org

c279d02

Changed the CUSTOM_FILE_REPO constant to use fixtures.pulpproject and skipped all tests affected by DRPM, SRPM, and FAKE_7_YUM_REPO. New DRPM, SRPM, and FAKE_7_YUM_REPO will need to be created manually and ran locally.

Griffin-Sullivan force-pushed the drpm-srpm branch from 81d228f to 0efcf28 Compare July 6, 2020 13:31

Griffin-Sullivan changed the title ~~Switched SRPM, DRPM, and large_errata repos to pulpproject~~ Converted constants using pulp fixtures in fedorapeople to fixtures.pulpproject Jul 6, 2020

mshriver approved these changes Jul 7, 2020

View reviewed changes

JacobCallahan approved these changes Jul 27, 2020

View reviewed changes

JacobCallahan merged commit 4d61966 into SatelliteQE:master Jul 27, 2020

Griffin-Sullivan deleted the drpm-srpm branch March 4, 2022 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Converted constants using pulp fixtures in fedorapeople to fixtures.pulpproject #7852

Converted constants using pulp fixtures in fedorapeople to fixtures.pulpproject #7852

Griffin-Sullivan commented Jun 24, 2020 •

edited

Loading

codecov bot commented Jun 24, 2020 •

edited

Loading

swadeley Jun 25, 2020

JacobCallahan Jun 29, 2020

Griffin-Sullivan Jun 30, 2020

latran Jun 30, 2020 •

edited

Loading

swadeley left a comment •

edited

Loading

omkarkhatavkar left a comment

daviddavis commented Jun 26, 2020

Griffin-Sullivan commented Jun 26, 2020

daviddavis commented Jun 29, 2020 •

edited

Loading

Griffin-Sullivan commented Jun 29, 2020

Griffin-Sullivan commented Jul 6, 2020

swadeley commented Jul 6, 2020

Griffin-Sullivan commented Jul 6, 2020

latran commented Jul 6, 2020

Griffin-Sullivan commented Jul 6, 2020

swadeley commented Jul 6, 2020

swadeley commented Jul 6, 2020 •

edited

Loading

Griffin-Sullivan commented Jul 6, 2020

daviddavis commented Jul 7, 2020

JacobCallahan left a comment

Converted constants using pulp fixtures in fedorapeople to fixtures.pulpproject #7852

Converted constants using pulp fixtures in fedorapeople to fixtures.pulpproject #7852

Conversation

Griffin-Sullivan commented Jun 24, 2020 • edited Loading

codecov bot commented Jun 24, 2020 • edited Loading

Codecov Report

swadeley Jun 25, 2020

Choose a reason for hiding this comment

JacobCallahan Jun 29, 2020

Choose a reason for hiding this comment

Griffin-Sullivan Jun 30, 2020

Choose a reason for hiding this comment

latran Jun 30, 2020 • edited Loading

Choose a reason for hiding this comment

swadeley left a comment • edited Loading

Choose a reason for hiding this comment

omkarkhatavkar left a comment

Choose a reason for hiding this comment

daviddavis commented Jun 26, 2020

Griffin-Sullivan commented Jun 26, 2020

daviddavis commented Jun 29, 2020 • edited Loading

Griffin-Sullivan commented Jun 29, 2020

Griffin-Sullivan commented Jul 6, 2020

swadeley commented Jul 6, 2020

Griffin-Sullivan commented Jul 6, 2020

latran commented Jul 6, 2020

Griffin-Sullivan commented Jul 6, 2020

swadeley commented Jul 6, 2020

swadeley commented Jul 6, 2020 • edited Loading

Griffin-Sullivan commented Jul 6, 2020

daviddavis commented Jul 7, 2020

JacobCallahan left a comment

Choose a reason for hiding this comment

Griffin-Sullivan commented Jun 24, 2020 •

edited

Loading

codecov bot commented Jun 24, 2020 •

edited

Loading

latran Jun 30, 2020 •

edited

Loading

swadeley left a comment •

edited

Loading

daviddavis commented Jun 29, 2020 •

edited

Loading

swadeley commented Jul 6, 2020 •

edited

Loading