Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for satellite clone #9986

Merged
merged 8 commits into from
Oct 6, 2022

Conversation

LadislavVasina1
Copy link
Contributor

I have implemented tests for satellite clone. Fixture that provides suitable RHEL for sat (6 cores, 20 GiB) to be installed to has been added too because none of the existing fixtures was suitable for me.
While implementing the tests I have found the wrong keys for rhel content host parametrization and I have also found an incorrect list of repos needed for sat installation on RHEL8 ('ansible-2.9-for-rhel-8-x86_64-rpms' deleted from list).
image

@LadislavVasina1 LadislavVasina1 added the CherryPick PR needs CherryPick to previous branches label Aug 23, 2022
@omkarkhatavkar
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LadislavVasina1 Nice addition, thanks for the PR, I've a few suggestions/questions

robottelo/constants/__init__.py Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
robottelo/hosts.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
@LadislavVasina1 LadislavVasina1 marked this pull request as ready for review August 30, 2022 11:34
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/maintain/test_clone.py Outdated Show resolved Hide resolved
@LadislavVasina1
Copy link
Contributor Author

Adding pytest output so you can clearly see test parametrization


<Package destructive>
  <Module test_clone.py>
    <Function test_positive_clone_backup[skip_pulp-online-8]>
    <Function test_positive_clone_backup[skip_pulp-offline-8]>
    <Function test_positive_clone_backup[no_skip_pulp-online-8]>
    <Function test_positive_clone_backup[no_skip_pulp-offline-8]>

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with the current state of the PR, but I would like to get more feedback on my comments here. I will hold my ACK until the majority of them are answered.

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
I do not want to block this PR from merging anymore. However, we should implement the suggestions about dogfood_repofile presented in the review comments.

Copy link
Contributor

@lpramuk lpramuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the way maintenance repository is set up

tests/foreman/destructive/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/destructive/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/destructive/test_clone.py Outdated Show resolved Hide resolved
tests/foreman/destructive/test_clone.py Show resolved Hide resolved
@Gauravtalreja1 Gauravtalreja1 added the Tier 1 ACK A Tier 1 reviewer has ACK'd this PR label Sep 29, 2022
@Gauravtalreja1 Gauravtalreja1 requested a review from a team September 29, 2022 15:48
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work done here!
I thought we could create some content (function_product or some other fixture) before backup and assert it does exist on the target sat after clone. But this should be covered by backup/restore, so giving ACK. 👍

Copy link
Contributor

@lpramuk lpramuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial stage completed
In future we definitely should introduce entities population and checks after them in the clone

Also I'd like to have spinning just 1 source satellite instead of 10 for each test/datapoint

@lpramuk lpramuk merged commit df685d0 into SatelliteQE:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick PR needs CherryPick to previous branches Tier 1 ACK A Tier 1 reviewer has ACK'd this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants