-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for satellite clone #9986
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LadislavVasina1 Nice addition, thanks for the PR, I've a few suggestions/questions
Adding pytest output so you can clearly see test parametrization
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with the current state of the PR, but I would like to get more feedback on my comments here. I will hold my ACK until the majority of them are answered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
I do not want to block this PR from merging anymore. However, we should implement the suggestions about dogfood_repofile
presented in the review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the way maintenance repository is set up
4c34676
to
5a31bde
Compare
d2512da
to
69f588a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work done here!
I thought we could create some content (function_product
or some other fixture) before backup and assert it does exist on the target sat after clone. But this should be covered by backup/restore, so giving ACK. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial stage completed
In future we definitely should introduce entities population and checks after them in the clone
Also I'd like to have spinning just 1 source satellite instead of 10 for each test/datapoint
I have implemented tests for satellite clone. Fixture that provides suitable RHEL for sat (6 cores, 20 GiB) to be installed to has been added too because none of the existing fixtures was suitable for me.
While implementing the tests I have found the wrong keys for rhel content host parametrization and I have also found an incorrect list of repos needed for sat installation on RHEL8 ('ansible-2.9-for-rhel-8-x86_64-rpms' deleted from list).