Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like #181 fixes the TypeError that was originally reported in #167, but it didn't solve the fact that local files still caused an error. Upon further inspection, since an artist from a local file had a uri of
None
, and that was being passed intosp.artist
, that was still causing an error. Additionally, it could be possible that there are no artists associated, which would cause an IndexError.I added checks to ensure
sp.artist
Also, added a test for the local files case. It doesn't cover the case where the artist though. Additionally, I'm sourcing the playlist from one I created, which I could forget about and delete in the future, so I recommend creating your own playlist with songs from local files with an artist, and without an artist and replacing it in the test.
fixes #167