Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug risk informed by deepsource.io #207

Merged
merged 1 commit into from Oct 6, 2021

Conversation

Felipebros
Copy link
Contributor

https://deepsource.io/gh/SathyaBhat/spotify-dl/issue/PYL-R1722/occurrences?page=1

The exit or quit functions don't exist at top-level if python is started with the -S flag, and will raise an error. Use sys.exit() instead.

The exit and quit functions are actually site.Quitter objects and are loaded, at interpreter start up, from site.py. However, if the interpreter is started with the -S flag, or a custom site.py is used then exit and quit may not be present. It is recommended to use sys.exit() which is built into the interpreter and is guaranteed to be present.

https://deepsource.io/gh/SathyaBhat/spotify-dl/issue/PYL-R1722/occurrences?page=1

The exit or quit functions don't exist at top-level if python is started with the -S flag, and will raise an error. Use sys.exit() instead.

The exit and quit functions are actually site.Quitter objects and are loaded, at interpreter start up, from site.py. However, if the interpreter is started with the -S flag, or a custom site.py is used then exit and quit may not be present. It is recommended to use sys.exit() which is built into the interpreter and is guaranteed to be present.
@SathyaBhat
Copy link
Owner

Thank you for your contribution!

@Felipebros
Copy link
Contributor Author

It's nothing!, if you can label 'hacktoberfest-accepted' in PR to help me.

@SathyaBhat SathyaBhat merged commit e918d31 into SathyaBhat:master Oct 6, 2021
@Felipebros Felipebros deleted the patch-1 branch October 6, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants