Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore search highlighting, but with page visibility api #1

Open
1 of 3 tasks
SignpostMarv opened this issue Jan 18, 2021 · 0 comments
Open
1 of 3 tasks

restore search highlighting, but with page visibility api #1

SignpostMarv opened this issue Jan 18, 2021 · 0 comments
Assignees
@SignpostMarv
Labels
enhancement New feature or request

Comments

@SignpostMarv
Copy link
Collaborator

SignpostMarv commented Jan 18, 2021 •
edited

  • remove search position indexing from the prebuild stage.
  • Use the page visibility api to defer highlighting text until the element containing the transcript is visible.
  • highlight text by searching from the node walker results rather than the embedded transcript results.
@SignpostMarv SignpostMarv added the enhancement New feature or request label Jan 18, 2021
@SignpostMarv SignpostMarv self-assigned this Jan 18, 2021
SignpostMarv added a commit to Satisfactory-Clips-Archive/video-clip-notes that referenced this issue Jan 18, 2021
@SignpostMarv
dropping position markers re: /Satisfactory-Clips-Archive/Media-Searc…
92ee71a 
…h-Archive#1
SignpostMarv added a commit to Satisfactory-Clips-Archive/video-clip-notes that referenced this issue Jan 18, 2021
@SignpostMarv
positions were disabled in wrong file re: Satisfactory-Clips-Archive/…
ac6ec6d 
…Media-Search-Archive#1
SignpostMarv added a commit to Satisfactory-Clips-Archive/video-clip-notes that referenced this issue Feb 12, 2021
@SignpostMarv
dropping position markers re: /Satisfactory-Clips-Archive/Media-Searc…
c092c06 
…h-Archive#1
SignpostMarv added a commit to Satisfactory-Clips-Archive/video-clip-notes that referenced this issue Feb 12, 2021
@SignpostMarv
positions were disabled in wrong file re: Satisfactory-Clips-Archive/…
1a026dc 
…Media-Search-Archive#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SignpostMarv SignpostMarv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SignpostMarv