Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Bitcoin Core RPC and Protocol ports #130

Closed
Kexkey opened this issue Sep 20, 2019 · 4 comments
Closed

Separate Bitcoin Core RPC and Protocol ports #130

Kexkey opened this issue Sep 20, 2019 · 4 comments
Labels
configs/defaults changing defaults or configs enhancement New feature or request good first issue Good for newcomers Installer

Comments

@Kexkey
Copy link
Collaborator

Kexkey commented Sep 20, 2019

In setup, we ask if we want to expose Bitcoin ports (RPC and Protocol). That should be 2 different configs.

Do you want to expose RPC port?
Do you want to expose Protocol port?

@Kexkey Kexkey added enhancement New feature or request good first issue Good for newcomers Installer configs/defaults changing defaults or configs labels Sep 20, 2019
@phillamy
Copy link
Contributor

phillamy commented Nov 11, 2021

Currently, the installer says:

_? Installer: Expose bitcoin full node outside of the docker network?

By default, Bitcoin node port (P2P port) will NOT be published outside of Docker.
Do you want to expose it so that your node can be accessed from outside of the
Docker network?_

Should become 2 separate questions :

? Installer: Expose bitcoin full node P2P port outside of the docker network?

By default, Bitcoin node P2P port will NOT be published outside of Docker.
Do you want to expose it so that your node can be accessed from outside of the
Docker network?

? Installer: Expose bitcoin full node RPC port outside of the docker network?

By default, Bitcoin node RPC port will NOT be published outside of Docker.
Do you want to expose it so that your node can be accessed from outside of the
Docker network?

@Kexkey : Is it what you meant ?

@phillamy
Copy link
Contributor

After review with @Kexkey , RPC port will never be exposed outside of Docker network (done in feb 2020). So the actual question ==> Installer: Expose bitcoin full node outside of the docker network?

Will be changed to ==> Installer: Expose bitcoin full node P2P port outside of the docker network?

@phillamy
Copy link
Contributor

phillamy commented Nov 16, 2021

PR:
? Installer: Expose bitcoin full node P2P port outside of the docker network?

By default, Bitcoin node port (P2P port) will NOT be published outside of Docker.
Do you want to expose it so that your node can be accessed from outside of the
Docker network?

image

@Kexkey
Copy link
Collaborator Author

Kexkey commented Nov 18, 2021

#236

@Kexkey Kexkey closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs/defaults changing defaults or configs enhancement New feature or request good first issue Good for newcomers Installer
Projects
None yet
Development

No branches or pull requests

2 participants