Features/proxy generatoaddress #267
Conversation
|
I'd like the arguments to all be optional: if no Thanks!! |
| schema: | ||
| type: "object" | ||
| properties: | ||
| nbBlocks: |
There was a problem hiding this comment.
Make the arguments optional and the request HTTP-GET compatible
|
|
||
| local nbblocks=$(echo ${1} | jq '.nbblocks // 1') # Optional - Default 1 | ||
| local address=$(echo ${1} | jq '.address' // empty) # Optional - getnewadress from spender wallet | ||
| local maxtries=$(echo ${1} | jq '.maxtries // 1000000') # Optional - use Core default |
There was a problem hiding this comment.
I hard coded core default value - not using core's actual or futur default value. Would it be better to leave it empty if not specified ?
| @@ -72,6 +72,7 @@ action_removefrombatch=spender | |||
| action_listbatchers=spender | |||
| action_getbatcher=spender | |||
| action_getbatchdetails=spender | |||
| action_generatetoaddress=spender | |||
There was a problem hiding this comment.
It's actually bitcoin_generatetoaddress
This doesn't work when request goes through the gatekeeper.
Maybe we should add going through the gatekeeper in all the tests
| @@ -72,6 +72,7 @@ action_removefrombatch=spender | |||
| action_listbatchers=spender | |||
| action_getbatcher=spender | |||
| action_getbatchdetails=spender | |||
| action_generatetoaddress=spender | |||
There was a problem hiding this comment.
Oh I know, we should add the new endpoint to api_auth_docker/tests/test-gatekeeper.sh
|
All changes made |
Added a generatetoaddress in proxy. This lets the proxy/tests/tests.sh run without user having to mine 1 block