Allow ${INSTALLDIR}_build_target to be customized #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix. I unfortunately do not have Mac OS X for testing so this helps out a lot. I'm currently building the i686 GNU/Linux version on x86_64 GNU/Linux. As soon as it passes, I'll merge your changes. |
RedRingRico
pushed a commit
that referenced
this pull request
Feb 17, 2016
Allow ${INSTALLDIR}_build_target to be customized
|
Thanks! |
mistydemeo
added a commit
to mistydemeo/homebrew-formulae
that referenced
this pull request
Feb 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is to make it easier to include this in the Homebrew package manager for OS X.
Homebrew builds packages using OS X's sandbox, configured to only allow writes to the target directory (e.g.
INSTALLDIR) and to the temporary build directory. The step inbuild-canadian.shwhich moves the cross-compiler from${INSTALLDIR}to${INSTALLDIR}_build_targetresults in the cross-compiler being moved outside one of the sandbox-writable areas, so the install would fail. This patch lets the build_target directory be configured via theINSTALLDIR_BUILD_TARGETenvironment variable, which defaults to the same path as it does currently.I have a package for saturn-sdk-gcc-sh2 already, which works if the sandbox is disabled; I'm planning to move it into one of the official Homebrew repositories if this patch is accepted. Thanks!