Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Modularizing the project #150

Closed
5 tasks done
Ratangulati opened this issue May 22, 2024 · 4 comments
Closed
5 tasks done

BUG: Modularizing the project #150

Ratangulati opened this issue May 22, 2024 · 4 comments

Comments

@Ratangulati
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I am planning to use react-router to make the code more accessible by making a pages folder under src where all the pages will be stored and creating UI for the search screen from the Figma uploaded.

Record

  • I agree to follow this project's Code of Conduct
  • I have checked the existing issues
  • I'm a GSSOC'24 contributor
  • I want to work on this issue
Copy link

Congratulations, @Ratangulati! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work! As per GSSoC'24 guidelines the person who raises the issue should be assigned for that issue. But if that person doesn't want to work on that issue the first come fist policy is follwed.

We'd also like to invite you to our Discord server! Join us on discord.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Satyam1923
Copy link
Owner

@Ratangulati nice idea but how will you contribute since everyone is working on something else.

@Ratangulati
Copy link
Contributor Author

Ratangulati commented May 23, 2024

I can do it but everyone has to sync to the clone, they have to copy & paste their code to the new clone and start working on it as all the code remains same but the code of App.jsx will be moved under home page.
I think it is better to do it now before it becomes cluttered.

OR
we can create pages for other routes and let home page code remain in APP.jsx and when we are done with APP.jsx we can just shift it to the new folder as no one or a few will be working on it at that time.

What are your thoughts? @Satyam1923

@Ratangulati
Copy link
Contributor Author

Ratangulati commented May 23, 2024

Should I create the search page? @Satyam1923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants