Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated from master fork branch #1

Merged
merged 121 commits into from
Sep 27, 2020

Conversation

saurabh-mhaisekar
Copy link
Owner

No description provided.

MrOlolo and others added 30 commits September 10, 2020 23:11
[Feature] Ability to use tags with GetX widgets
fix(num) Fix num issues with operator overloads
- Fixes #441
- I understand `Object` was used, because Flutter's Route arguments uses it. Yet, seems it will not bring any breaking change, beyond removing all type checking to the `arguments` property. So, it gives full freedom (and responsibility) to the developer to make the proper validations.

Check responses in (we might need to validate the usage of extension methods over `dynamic`):
https://stackoverflow.com/questions/31257735/what-is-the-difference-between-dynamic-and-object-in-dart#:~:text=Writing%20dynamic%20o%3B%20declares%20a,except%20that%20it%27s%20an%20Object%20.
change `arguments` to dynamic (roadmap)
Added Persistent bottom sheet
Add more tests for string and num extensions
jonataslaw and others added 27 commits September 19, 2020 13:51
BottomSheet Duration && Export SingleGetTickerProvider
Update dependency_management.md
fix(unknownRoute): Fix customTransition being called on null
Adding Chinese documentation.
- Although "nasty" solution, multiple instances were created with one Get.find() when using Get.create(), now the actual instance created from `GetInstance::<S>_startController()` > `GetInstance::<S>_initDependencies()` > `GetInstance::<S>_find()` is returned.
- added docs and impl to `GetWidget` to make it work with **DI** `tag`, I place it in the constructor directly (to use with `:super( tag: "something")` )... but we might actually use an override getter as well if needed.
Reverted GetWidget to original implementation ( to use with `@override`), added docs, renamed "name" to "tag" in `Get.create()` to be consistent with the rest of the GetInstance() methods.
Fixes Get.create() and GetWidget()
@saurabh-mhaisekar saurabh-mhaisekar merged commit cffe9fd into saurabh-mhaisekar:master Sep 27, 2020
@jonataslaw jonataslaw deleted the master branch September 27, 2020 15:28
@jonataslaw jonataslaw restored the master branch September 27, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.