forked from jonataslaw/getx
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated from master fork branch #1
Merged
saurabh-mhaisekar
merged 121 commits into
saurabh-mhaisekar:master
from
jonataslaw:master
Sep 27, 2020
Merged
Updated from master fork branch #1
saurabh-mhaisekar
merged 121 commits into
saurabh-mhaisekar:master
from
jonataslaw:master
Sep 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… original objects
[Feature] Ability to use tags with GetX widgets
fix(num) Fix num issues with operator overloads
fix isNullOrBlank function
- Fixes #441 - I understand `Object` was used, because Flutter's Route arguments uses it. Yet, seems it will not bring any breaking change, beyond removing all type checking to the `arguments` property. So, it gives full freedom (and responsibility) to the developer to make the proper validations. Check responses in (we might need to validate the usage of extension methods over `dynamic`): https://stackoverflow.com/questions/31257735/what-is-the-difference-between-dynamic-and-object-in-dart#:~:text=Writing%20dynamic%20o%3B%20declares%20a,except%20that%20it%27s%20an%20Object%20.
change `arguments` to dynamic (roadmap)
Added Persistent bottom sheet
Add more tests for string and num extensions
BottomSheet Duration && Export SingleGetTickerProvider
Update dependency_management.md
fix(unknownRoute): Fix customTransition being called on null
Adding Chinese documentation.
Fix of Issue #643
- Although "nasty" solution, multiple instances were created with one Get.find() when using Get.create(), now the actual instance created from `GetInstance::<S>_startController()` > `GetInstance::<S>_initDependencies()` > `GetInstance::<S>_find()` is returned. - added docs and impl to `GetWidget` to make it work with **DI** `tag`, I place it in the constructor directly (to use with `:super( tag: "something")` )... but we might actually use an override getter as well if needed.
Fixes Get.create() and GetWidget()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.