fix: typed components update fix (#78)

SauravKanchan · Sep 20, 2022 · 2a34f4f · 2a34f4f
1 parent 9c074ca
commit 2a34f4f
Show file tree

Hide file tree

Showing 10 changed files with 26 additions and 10 deletions.
diff --git a/.size-limit.cjs b/.size-limit.cjs
@@ -16,7 +16,7 @@ module.exports = [
   },
   {
     path: 'package/index.js',
-    limit: '1.2 KB',
+    limit: '1.25 KB',
     import: '{ Bar }',
     modifyWebpackConfig
   },

diff --git a/src/Bar.svelte b/src/Bar.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(BarController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="bar" {...props} />
diff --git a/src/Bubble.svelte b/src/Bubble.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(BubbleController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="bubble" {...props} />
diff --git a/src/Chart.svelte b/src/Chart.svelte
@@ -45,7 +45,7 @@
     if (!chart) return;
 
     chart.data = data;
-    chart.options = options;
+    Object.assign(chart.options, options);
     chart.update(updateMode);
   });
 

diff --git a/src/Doughnut.svelte b/src/Doughnut.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(DoughnutController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="doughnut" {...props} />
diff --git a/src/Line.svelte b/src/Line.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(LineController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="line" {...props} />
diff --git a/src/Pie.svelte b/src/Pie.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(PieController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="pie" {...props} />
diff --git a/src/PolarArea.svelte b/src/PolarArea.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(PolarAreaController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="polarArea" {...props} />
diff --git a/src/Radar.svelte b/src/Radar.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(RadarController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="radar" {...props} />
diff --git a/src/Scatter.svelte b/src/Scatter.svelte
@@ -13,10 +13,12 @@
   ChartJS.register(ScatterController);
 
   export let chart: $$Props['chart'] = null;
-  let props = $$props as $$Props;
+  let props: $$Props;
   let baseChartRef: Chart;
 
   useForwardEvents(() => baseChartRef);
+
+  $: props = $$props as $$Props;
 </script>
 
 <Chart bind:this={baseChartRef} bind:chart type="scatter" {...props} />