Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated blog.html to close issue #605 #685

Merged
merged 1 commit into from Oct 23, 2022
Merged

Updated blog.html to close issue #605 #685

merged 1 commit into from Oct 23, 2022

Conversation

Sumedh-byte
Copy link
Contributor

🛠️ Fixes Issue

close #605

👨‍💻 Changes proposed

  1. The icons of the blog.html page have to be same as in index.html page.
  2. Edited and updated the icons in blog.html corresponding as in index.html page.

✔️ Check List (Check all the applicable boxes)

  • [✔️] My code follows the code style of this project.
  • [✔️] This PR does not contain plagiarized content.
  • [✔️] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@netlify
Copy link

netlify bot commented Oct 15, 2022 •
edited

✅ Deploy Preview for codeincommunity ready!

Name Link
🔨 Latest commit 416522a
🔍 Latest deploy log https://app.netlify.com/sites/codeincommunity/deploys/634b06896e6ca9000d571e66
😎 Deploy Preview https://deploy-preview-685--codeincommunity.netlify.app/blog
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tamalCodes tamalCodes added bug Something isn't working good first issue Good for newcomers Hacktoberfest-accepted 🚦 status : Requested changes Changes have been requested for these PRs labels Oct 19, 2022
tamalCodes
tamalCodes requested changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please attach the screenshots of the changes that you made ?

@PS-11
Copy link

PS-11 commented Oct 22, 2022

@iamtamal Please assign this issue to me if it's still available.

Sumedh-byte
Sumedh-byte commented Oct 22, 2022
View reviewed changes
Copy link
Contributor Author

@Sumedh-byte Sumedh-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing Screenshot of updated blog.html file
image

@Sumedh-byte
Copy link
Contributor Author

@iamtamal I have uploaded the screenshot. Please review it.

tamalCodes
tamalCodes approved these changes Oct 22, 2022
View reviewed changes
Copy link
Collaborator

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , will be merged soon ✅

Also @Sumedh-byte by "changes" i meant a screenshot of this :
image

Not the one you gave.

@tamalCodes tamalCodes added ☑ status : Approved by 1 maintainer Saurav will merge this, approved by other maintainers. and removed 🚦 status : Requested changes Changes have been requested for these PRs labels Oct 22, 2022
@SauravMukherjee44 SauravMukherjee44 merged commit efa72f6 into SauravMukherjee44:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SauravMukherjee44 SauravMukherjee44 SauravMukherjee44 approved these changes

@tamalCodes tamalCodes tamalCodes approved these changes

Assignees

@Sumedh-byte Sumedh-byte

Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest-accepted ☑ status : Approved by 1 maintainer Saurav will merge this, approved by other maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in blog.html page
4 participants
@Sumedh-byte @PS-11 @SauravMukherjee44 @tamalCodes