Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom platform and target through npm environment #189

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Add custom platform and target through npm environment #189

merged 3 commits into from
Sep 11, 2021

Conversation

Lion7de
Copy link

@Lion7de Lion7de commented Sep 11, 2021

Proposal for #188

@SavageCore SavageCore self-requested a review September 11, 2021 18:34
@SavageCore SavageCore linked an issue Sep 11, 2021 that may be closed by this pull request
@Lion7de
Copy link
Author

Lion7de commented Sep 11, 2021

Lint issues should be fixed now

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #189 (b35d979) into master (5f6bd59) will increase coverage by 1.21%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   86.66%   87.87%   +1.21%     
==========================================
  Files           2        2              
  Lines          30       33       +3     
==========================================
+ Hits           26       29       +3     
  Misses          4        4              
Impacted Files Coverage Δ
index.js 85.18% <88.88%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6bd59...b35d979. Read the comment docs.

@SavageCore SavageCore merged commit 9b87f39 into SavageCore:master Sep 11, 2021
@SavageCore
Copy link
Owner

Thanks for this! Will get a new version out ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize target architecture via npm
3 participants