Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix darwin-arm64 platform, remove libxcb dependency #203

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

wongyiuhang
Copy link
Contributor

#200

Works great if brew install ffpmeg or brew uninstall ffmpeg gets executed

Only problem is if Homebrew gets uninstall or if brew install ffpmeg has never been executed prior

Error

dyld[89086]: Library not loaded: /opt/homebrew/opt/libxcb/lib/libxcb.1.dylib
  Referenced from: /Users/mohamedbakoush/Documents/GitHub/node-ffprobe-installer/platforms/darwin-arm64/ffprobe
  Reason: tried: '/opt/homebrew/opt/libxcb/lib/libxcb.1.dylib' (no such file), '/usr/local/lib/libxcb.1.dylib' (no such file), '/usr/lib/libxcb.1.dylib' (no such file)

As discussed and tested with @MohamedBakoush. The ffprobe for darwin-arm64 has been re-compiled again with removing external libxcb dependency.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #203 (e0e63b8) into master (3584022) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   87.87%   87.87%           
=======================================
  Files           2        2           
  Lines          33       33           
=======================================
  Hits           29       29           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3584022...e0e63b8. Read the comment docs.

@wongyiuhang
Copy link
Contributor Author

Here's a doc for future on how to re-build ffprobe without libxcb

Build Independent ffprobe on macOS

@Kikobeats Kikobeats merged commit edb835a into SavageCore:master Jan 10, 2022
@Kikobeats
Copy link
Collaborator

Thanks a lot!

@MohamedBakoush
Copy link

Any info on when this gets published to NPM?

@Kikobeats
Copy link
Collaborator

v1.4.0 published 🎉

@SavageCore
Copy link
Owner

v1.4.0 published 🎉

Thank you, Kiko!

@MohamedBakoush
Copy link

I tried npm i @ffprobe-installer/ffprobe v1.4.0 and it didnt work, when i checked the SHA1 hash it was 1dd6aab8b1880c44cc98db96f950634ad701848a (old version) while its seposed to be 384491447b76b483cfd32c99e9f6327f201e19a3 makeing me think darwin-arm64 binaries didn't get published to NPM.

While a new version of this repo can be seen at https://www.npmjs.com/package/@ffprobe-installer/ffprobe/v/1.4.0

https://www.npmjs.com/package/@ffprobe-installer/darwin-arm64 has not been updated.

Looking at previous commits - example from v1.2.0 9c730ff and 6d64316, it seems new version number needs to be given to

for the new 384491447b76b483cfd32c99e9f6327f201e19a3 FFprobe binary to get published

If am wrong and NPM just needs time please ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants