Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darwin-arm64] Update binaries #248

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Conversation

wongyiuhang
Copy link
Contributor

As discussed in #200 (comment), a new version of ffprobe on darwin-arm64 is compiled.

@JuanIrache, may you help and confirm the new binary extracts rotation before we merge the update? Thank you馃檹

ffprobe(5.1.2)

@JuanIrache
Copy link

I will run some tests and get back to you. Thank you!

@SavageCore SavageCore self-requested a review February 16, 2023 12:22
@wongyiuhang
Copy link
Contributor Author

@SavageCore, in this PR, I have bumped the NPM package version from 5.0.1 to 5.1.2, which reflects the ffprobe version. Is that okay? Or shall I change back to 5.1.0, which aligns with other architecture package versions?

@SavageCore
Copy link
Owner

No problem, the versions are essentially useless as they are now, at least this one will have meaning :)

@JuanIrache
Copy link

@JuanIrache, may you help and confirm the new binary extracts rotation before we merge the update? Thank you馃檹

Orientation works great, thank you! This binary does not exactly work for my use case, as it does not include things like libxcb and libSDL2 statically (typically included in static binaries like these), but I suppose that's beyond the scope of this project.

@SavageCore SavageCore merged commit 148cb8b into SavageCore:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants