fix(injector): inject as singleton when scope !== REQUEST by default

Savory · Oct 13, 2022 · 0918ffd · 0918ffd
1 parent e7f8a3c
commit 0918ffd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/spec/injection.test.ts b/spec/injection.test.ts
@@ -18,6 +18,7 @@ import { HttpContext } from '../src/router/router.ts';
 Deno.test('Injection', async (testContext) => {
 	interface IDBService {
 		data: string;
+		id: string;
 	}
 
 	@Injectable()
@@ -49,8 +50,9 @@ Deno.test('Injection', async (testContext) => {
 	@Injectable()
 	class DatabaseService implements IDBService {
 		public data = 'coucou';
-
+		public id = crypto.randomUUID();
 		constructor() {
+			console.log('we construct');
 		}
 	}
 
@@ -153,6 +155,7 @@ Deno.test('Injection', async (testContext) => {
 			const singletonController = await app.get(SingletonController)!;
 			assertInstanceOf(singletonController.child2, GlobalInjectable);
 			assertInstanceOf(singletonController.dbService, DatabaseService);
+			assertEquals(firstController.child1.dbService.id, singletonController.dbService.id);
 		},
 	);
 

diff --git a/src/injector/injector.ts b/src/injector/injector.ts
@@ -126,7 +126,7 @@ export class Injector {
 			Type,
 		);
 		await this.resolveDependencies(dependencies, actualType);
-		if (injectableMetadata?.scope === SCOPE.GLOBAL) {
+		if (injectableMetadata?.scope !== SCOPE.REQUEST) {
 			const resolvedDependencies = new Array<Constructor>();
 			for (const [idx, Dep] of dependencies.entries()) {
 				resolvedDependencies.push(