Feat(test): giving some love to tests #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's quite common to look at tests when docs are not enough, especially for specific use case.
In its current state, the code is not showing using the framework in the most elegant way and we still have a few URL dependencies.
This PR aim to improve all those points by giving some love to the tests <3
It also introduce a single breaking change which is to change the default value for the
port
parameter ofDanetApplication.listen()
from3000
to0
. Most respectable frameworks (Express, NestJS, Oak, etc.) will use 0 if no port is provided, why not Danet!Type of change
Checklist:
deno lint
ANDdeno fmt
ANDdeno task test
and got no errors.