build: Respect $(LIBTOOL) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building librep with slibtool (https://dev.midipix.org/cross/slibtool) it will ignore the value of
$(LIBTOOL)in a few places which ends up with the build attempting to use both slibtool and GNU libtool which will not work. It is better to consistently use$(LIBTOOL)so that either libtool implementation can be used.This can be fixed by simply removing
rep_LIBTOOL.Please see this downstream issue: https://bugs.gentoo.org/790812
Note: librep will not fully build with slibtool yet, there also appears to be an issue on the slibtool side with
--mode=executewhich should hopefully be resolvable soon, but regardless this fix would be helpful sooner rather than later. The build should of course continue to work with GNU libtool in the mean time.