added dummy X reg # 15 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floswald
requested changes
Jun 4, 2018
| rect(xleft = x, ybottom = y, | ||
| xright = x + abs(errors), ytop = y + errors, density = -1, | ||
| col = rgb(red = 1, green = 0, blue = 0, alpha = 0.05), border = NA) | ||
| } |
There was a problem hiding this comment.
it shows a warning
Warning in plot.xy(xy.coords(x, y), type = type, ...) :
"add" is not a graphical parameter
| sidebarPanel(sliderInput("i_dummy", "Intercept", min = 0, | ||
| max = 5, step = .25, value = 5), | ||
| sliderInput("s_dummy", "Slope", min = -1, | ||
| max = 5, step = .25, value = .25), |
There was a problem hiding this comment.
start at a better slope or it's hard to get started. 3?
|
a comment to the older plots in that PR: for Fit with no slope it would be great if you could fix the x-axis for both versions - with and without demeaned data. it would be great to just see the cloud of points shift. the changing xaxix masks this a bit. |
|
Ok, will do |
|
Done, will push this pm. |
floswald
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #15,
I kept it simple