--code-style argument will cause error

[darwin67]

Summary

1.2.0 got released today, and CI is failing for us using latest.

ktlint version: ktlint version 1.2.0
Parameter '--code-style' is no longer valid. The code style should be defined as '.editorconfig' property 'ktlint_code_style='
reviewdog: parse error: EOF

Seems like this has been deprecated for a while now, so perhaps time to remove it?

Expected behavior

CI runs

Current behavior

ktlint will return an error without executing.

[cp-megh-l]

+1

[ffuf-libre]

+1

[guil-camp-scacap]

Until it is fixed, a workaround to get builds working again is to explicitly set the ktlint version to a previous one (i.e. 1.1.1)

  with:
        ...
        ktlint_version: 1.1.1
        ...

[ghaiszaher]

Thanks for reporting. The action should not be using --code-style for versions after 1.0.0. However, in the new ktlint version, the command ktlint --version doesn't simply return the version 1.2.0 but rather ktlint version 1.2.0 for some reason. So the comparison is now failing.

Our goal in the entrypoint script was to make it work with any ktlint version so we have a logic of comparing versions and passing different values for android support.

Should be fixed with #50

[ghaiszaher]

Fixed with #51