Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration always set to default values due to naming error #288

Closed
lgajowy opened this issue Jan 28, 2022 · 1 comment
Closed

Configuration always set to default values due to naming error #288

lgajowy opened this issue Jan 28, 2022 · 1 comment
Assignees
@worekleszczy
Labels
bug Something isn't working
Milestone
Release 0.6.0

Comments

@lgajowy
Copy link
Contributor

lgajowy commented Jan 28, 2022

When MesmerModule gets initialized, mesmerConfig value gets initialized to "module.null". Later in code this is used to determine what is the path to a config section in application.conf file. Since there is no such config entry, default values are always set. Effectively the modules are not configurable.
@lgajowy lgajowy added the bug Something isn't working label Jan 28, 2022
@lgajowy lgajowy mentioned this issue Jan 28, 2022
Closed
6 tasks
lgajowy added a commit that referenced this issue Jan 28, 2022
@lgajowy
Use Akka's global config when running with otel agent
062940c 
Previously, I wanted to configure everything with otel configuration mechanism. Now
 I'm not sure if this is the best idea so I decided to postpone adding the otel
config.

I also discovered a bug: #288
lgajowy added a commit that referenced this issue Jan 31, 2022
@lgajowy
Use Akka's global config when running with otel agent
694055b 
Previously, I wanted to configure everything with otel configuration mechanism. Now
 I'm not sure if this is the best idea so I decided to postpone adding the otel
config.

I also discovered a bug: #288
lgajowy added a commit that referenced this issue Jan 31, 2022
@lgajowy
Use Akka's global config when running with otel agent
9d9df76 
Previously, I wanted to configure everything with otel configuration mechanism. Now
 I'm not sure if this is the best idea so I decided to postpone adding the otel
config.

I also discovered a bug: #288
@lgajowy lgajowy added this to the Release 0.5.2 milestone Feb 8, 2022
@lgajowy lgajowy mentioned this issue Mar 1, 2022
Closed
@lgajowy
Copy link
Contributor Author

lgajowy commented Mar 25, 2022

This is not happening anymore because we use the otel config now that works differently.

@lgajowy lgajowy closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worekleszczy worekleszczy

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.6.0
Development

No branches or pull requests
2 participants
@lgajowy @worekleszczy