-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't close subscriber if channel is recoverable. #49
base: master
Are you sure you want to change the base?
Conversation
LGTM |
What's the status here? |
Hi @pribor! Can you rebase? |
ad26102
to
f8d6b18
Compare
Done |
I tried it: killed rabbit, started it again, but my streams didn't resume.. |
9d5fb44
to
531d688
Compare
Is there any chance that this PR will be accepted? |
It's been a while since this PR is opened, what is the reason for not merging it? |
Bump, with the above question. |
Can someone confirm if this works? |
I'm using it in staging environment and it seems to be working. |
Hi guys, it works very well ! Is it possible to merge it ? (BTW more than the branch conflict, I was forced to refactor a little bit the code to build it in scala 2.12) |
Hey folks, We are actively using this fix in production. We had to pin to it in order to continue using this library. We would very much appreciate having this PR merged. If we can help in any way please let me know. |
What's the pb with this PR ? @mkiedys ? What should we do to make you accept it ? |
Just want to add our voice to the mix. We are having a issue in production caused by this bug. We are going to deploy our own version based on this PR. Would love to see this PR get merged in the near future! Thanks for a great library! |
The reason why this stayed open so long are:
I'm looking into this right now. |
What's the relationship to #64? |
I made some changes to make the auto recovery work.
handleCancel
method.QueuePublisher
registers shutdown listeners toQueueSubscription
.QueueSubscription
termination.