Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make langtrace compatible with OTEL collector #182

Conversation

dylanzuber-scale3
Copy link
Collaborator

@dylanzuber-scale3 dylanzuber-scale3 commented Jul 11, 2024

This PR updates the core span ingestion route to ingest spans collected from a OTEL collector. Note that this supports only OTLP spans and NOT metrics yet. And this support json on the transport layer.

@karthikscale3 karthikscale3 changed the title Dylan/s3en 2498 make langtrace compatible with otel collector Make langtrace compatible with OTEL collector Jul 12, 2024
@codefromthecrypt
Copy link

can you add a desc about what this means? I assume it means accept OTLP span (not also metrics) data, on the HTTP transport (not sure json or proto, but I think most are accepting proto)

@karthikscale3
Copy link
Contributor

can you add a desc about what this means? I assume it means accept OTLP span (not also metrics) data, on the HTTP transport (not sure json or proto, but I think most are accepting proto)

can you add a desc about what this means? I assume it means accept OTLP span (not also metrics) data, on the HTTP transport (not sure json or proto, but I think most are accepting proto)

Thank you and apologies for the confusion. Updated the description. This change support OTLP span on json http transport. We plan to support metrics soon and proto is on the near term roadmap for us.

@karthikscale3 karthikscale3 merged commit b15d242 into development Jul 23, 2024
@karthikscale3 karthikscale3 deleted the dylan/s3en-2498-make-langtrace-compatible-with-otel-collector branch July 23, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants