Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add custom time zones to AmazonMarketplaceAdvertisingTimeZone #365

Closed
sravyadalavai-vl opened this issue Apr 26, 2021 · 4 comments
Closed
Labels

Comments

@sravyadalavai-vl
Copy link

I am connecting to amazon api through ScaleLeap/amazon-advertising-api-sdk. While using the profile api i am getting error :
Invalid value "Europe/Amsterdam" supplied to Array. Later I debugged the code, then i found that the particular time zone is not available in time zone list. Could please add it by your self or give the sample code for how to add extra time zones to that list.
If i added these lines
EUROPE_AMSTERDAM = "Europe/Amsterdam"
AmazonMarketplaceAdvertisingTimeZone["EUROPE_AMSTERDAM"] = "Europe/Amsterdam";
in amazon-marketplace.d.ts, amazon-marketplace.js then profile api returning the profiles list.

@moltar
Copy link
Collaborator

moltar commented Apr 27, 2021

Is this for NL marketplace?

The docs do say it is supposed to be Europe/Paris, so there seems to be a mismatch.

image

@sravyadalavai-vl
Copy link
Author

Yes for country Code NL. I am getting this response from api
{"countryCode":"NL","currencyCode":"EUR","dailyBudget":999999999,"timezone":"Europe/Amsterdam","accountInfo":{"marketplaceStringId":".....","id":".....","type":"......","name":"....."}}

@moltar
Copy link
Collaborator

moltar commented Apr 27, 2021

Ok, thanks. Opened a ticket ADAPI-8644 with AA Jira to confirm this change. I will fix once they confirm that implementation is in fact the source truth and not the docs.

Thanks for reporting.

@repo-ranger repo-ranger bot closed this as completed in 72bd0b4 Apr 28, 2021
github-actions bot pushed a commit that referenced this issue Apr 28, 2021
## [11.0.1](v11.0.0...v11.0.1) (2021-04-28)

### Bug Fixes

* changes time zone for NL to Europe/Amsterdam ([72bd0b4](72bd0b4)), closes [#365](#365)
@github-actions
Copy link

🎉 This issue has been resolved in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants