Migration from 17.3.0 to 18.0.0 - Cannot find module '@scaleleap/amazon-marketplaces' or its corresponding type declarations #634
Assignees
Labels
Comments
nguyentoanit
added a commit
that referenced
this issue
May 13, 2024
There was a bug when deleting `@scaleleap/utils` package from our repository. Including `"test/**/*.ts"` into `tsconfig.json` leaded to loosing entry points in the build. https://github.com/ScaleLeap/amazon-marketplaces/pull/619/files#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R12 Closes #634 ;
github-actions bot
pushed a commit
that referenced
this issue
May 13, 2024
## [18.0.1](v18.0.0...v18.0.1) (2024-05-13) ### Bug Fixes * entry points in the build ([#635](#635)) ([9ceab9a](9ceab9a)), closes [/github.com//pull/619/files#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R12](https://github.com//github.com/ScaleLeap/amazon-marketplaces/pull/619/files/issues/diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R12) [#634](#634)
|
🎉 This issue has been resolved in version 18.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@xhuberdeau: This issue should be addressed in |
Wow, thanks for the quick fix 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Thanks for this repository!
I'm trying to migrate this dependency from 17.3.0 to 18.0.0 but typescript shows me an error:
.
I digged a bit hoping this might help: the difference I see in the node_modules between 17.3.0 and 18.0.0 is that now, the lib files are not directly in the lib folder but in a src subfolder. So the
typesproperty in the package.json seems wrong as it's pointing to a non-existing file (it should belib/src/index.d.tsinstead oflib/index.d.ts)Version 17.3.0
Version 18.0.0
Tell me if you need more information 🙂
The text was updated successfully, but these errors were encountered: