fix: handle non-xml errors

src/http.ts

@@ -176,6 +176,10 @@ export class HttpClient {
     try {
       return await this.fetch(config).then((x) => parseResponse(x))
     } catch (error) {
+      if (parser.validate(error) !== true) {
+        throw error
+      }
+
       const maybeResponse = MWSApiError.decode(parser.parse(error))
 
       if (maybeResponse.isRight()) {
@@ -197,9 +201,9 @@ export class HttpClient {
         const ErrorToThrow = errorMap[errorCode]
 
         throw enhanceError(new ErrorToThrow(`${info.action} request failed`), response)
+      } else {
+        throw error
       }
-
-      throw error
     }
   }
 }

test/unit/http.test.ts

@@ -1,31 +1,76 @@
-import { amazonMarketplaces, HttpClient, InvalidParameterValue } from '../../src'
+import {
+  amazonMarketplaces,
+  HttpClient,
+  HttpError,
+  InvalidParameterValue,
+  MWSError,
+} from '../../src'
 import { Resource } from '../../src/http'
 import { getFixture } from '../utils'
 
+const httpClientThatThrows = (error: unknown) =>
+  new HttpClient(
+    {
+      awsAccessKeyId: '',
+      marketplace: amazonMarketplaces.CA,
+      mwsAuthToken: '',
+      secretKey: '',
+      sellerId: '',
+    },
+    () => {
+      throw error
+    },
+  )
+
+const mockRequest = {
+  resource: Resource.Sellers,
+  version: '',
+  action: 'GetServiceStatus',
+  parameters: {},
+} as const
+
 describe('httpClient', () => {
   it('should throw a HttpError on failure', async () => {
     expect.assertions(1)
 
-    const httpClient = new HttpClient(
-      {
-        awsAccessKeyId: '',
-        marketplace: amazonMarketplaces.CA,
-        mwsAuthToken: '',
-        secretKey: '',
-        sellerId: '',
-      },
-      () => {
-        throw getFixture('error-response')
-      },
+    const httpClient = httpClientThatThrows(getFixture('error-response'))
+
+    await expect(() => httpClient.request('POST', mockRequest)).rejects.toStrictEqual(
+      new InvalidParameterValue('GetServiceStatus request failed'),
     )
+  })
+
+  it('should throw a HttpError that can be handled', async () => {
+    expect.assertions(7)
+
+    const httpClient = httpClientThatThrows(getFixture('error-response'))
+
+    let expectedError!: InvalidParameterValue
+
+    try {
+      await httpClient.request('POST', mockRequest)
+    } catch (error) {
+      expectedError = error
+    }
 
-    await expect(() =>
-      httpClient.request('POST', {
-        resource: Resource.Sellers,
-        version: '',
-        action: 'GetServiceStatus',
-        parameters: {},
-      }),
-    ).rejects.toStrictEqual(new InvalidParameterValue('GetServiceStatus request failed'))
+    expect(expectedError instanceof MWSError).toStrictEqual(true)
+    expect(expectedError instanceof HttpError).toStrictEqual(true)
+    expect(expectedError instanceof InvalidParameterValue).toStrictEqual(true)
+    expect(expectedError.code).toStrictEqual('InvalidParameterValue')
+    expect(expectedError.type).toStrictEqual('Sender')
+    expect(expectedError.requestId).toStrictEqual('e26147f9-30cc-4379-9fb5-bd4ad966c48b')
+    expect(expectedError.mwsMessage).toStrictEqual(
+      'CreatedAfter or LastUpdatedAfter must be specified',
+    )
+  })
+
+  it('should propagate non-API errors', async () => {
+    expect.assertions(1)
+
+    const httpClient = httpClientThatThrows(new Error('Out of memory'))
+
+    await expect(() => httpClient.request('POST', mockRequest)).rejects.toStrictEqual(
+      new Error('Out of memory'),
+    )
   })
 })