Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

PaymentMethodDetails isn't mandatory #293

Closed
m-dierker opened this issue Jan 24, 2021 · 3 comments
Closed

PaymentMethodDetails isn't mandatory #293

m-dierker opened this issue Jan 24, 2021 · 3 comments
Labels

Comments

@m-dierker
Copy link
Contributor

Error from prod usage:

ParsingError
Problem with the value of property "ListOrdersResponse"
Problem with the value of property "ListOrdersResult"
Problem with the value of property "Orders"
Problem with value at index 3
Problem with property "PaymentMethodDetails"
it does not exist in received object {"LatestShipDate":"2021-01-01T00:00:00Z","OrderType":"StandardOrder","PurchaseDate":"2021-01-01T00:00:00Z","AmazonOrderId":"123-1234567-1234567","LastUpdateDate":"2021-01-01T00:00:00Z","IsReplacementOrder":true,"NumberOfItemsShipped":0,"ShipServiceLevel":"Expedited","OrderStatus":"Pending","SalesChannel":"Amazon.com","IsBusinessOrder":false,"NumberOfItemsUnshipped":1,"IsGlobalExpressEnabled":false,"IsSoldByAB":false,"IsPremiumOrder":false,"EarliestShipDate":"2021-01-01T00:00:00Z","MarketplaceId":"ASIN","FulfillmentChannel":"AFN","PaymentMethod":"Other","ReplacedOrderId":"123-1234567-1234567","IsISPU":false,"IsPrime":false,"SellerOrderId":"123-1234567-1234567","ShipmentServiceLevelCategory":"Expedited"}
    at Object.Left (/workspace/node_modules/@scaleleap/amazon-mws-api-sdk/lib/sections/orders.js:263:23)
    at Left.caseOf (/workspace/node_modules/purify-ts/Either.js:269:58)
    at Orders.listOrders (/workspace/node_modules/@scaleleap/amazon-mws-api-sdk/lib/sections/orders.js:260:52)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async /workspace/lib/index.js:29:25

Looks like a replacement order doesn't have PaymentMethodDetails which causes an error.

@moltar
Copy link
Contributor

moltar commented Jan 25, 2021

@mvd7793 can you submit a PR please? I'll approve it promptly. Otherwise will get it done next week.

@moltar
Copy link
Contributor

moltar commented Jan 25, 2021

If you provide a PR, please use fix: prefix in your commit, which will trigger a release.

@moltar moltar closed this as completed in eaeb00d Feb 1, 2021
github-actions bot pushed a commit that referenced this issue Feb 1, 2021
## [1.9.32](v1.9.31...v1.9.32) (2021-02-01)

### Bug Fixes

* marks PaymentMethodDetails as optional ([eaeb00d](eaeb00d)), closes [#293](#293)
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This issue has been resolved in version 1.9.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants