Offline Failure #417
Comments
@fny Sure, looks about right. Please submit a PR, and we will merge. Thanks! |
Do you all have any preference for what the return types should look like? |
Not sure what you mean. Can you please provide a bit more context? Thanks! |
Right now you all have In the other two cases what do you want to return?
|
I don't think there should be any return if there is an error. Throw a custom error object, if the error is specific and needs handling, or just re-throw the original error. |
We already have many error classes defined in: https://github.com/ScaleLeap/amazon-mws-api-sdk/blob/master/src/error.ts |
@fny have you tested this, can this be closed? |
.data
will not be available if the server loses connection to the internet or the MWS servers are down.amazon-mws-api-sdk/src/http.ts
Line 318 in 7ec2630
A few more cases are required to test for a failure.
The text was updated successfully, but these errors were encountered: