fix(cmd): addons-info working for non-db addons #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curzolapierre
force-pushed
the
fix/1054/addons-info_for_non_db_addon
branch
from
0ac01c3
to
2bffb48
Compare
ipfaze
reviewed
Mar 27, 2024
db/utils.go
Outdated
| package db | ||
|
|
||
| var ( | ||
| SupportedDatabases = []string{"PostgreSQL", "InfluxDB", "MongoDB", "MySQL"} |
There was a problem hiding this comment.
question: no Redis? no Elasticsearch?
There was a problem hiding this comment.
Yep that a regression, my bad. Nice catch
| return strings.EqualFold(s, addonInfo.AddonProvider.ID) | ||
| }) | ||
|
|
||
| dbInfo := [][]string{} |
There was a problem hiding this comment.
nitpick: dbInfo is used for database information but also for other addon information after the condition.
I suggest:
Suggested change
| dbInfo := [][]string{} | |
| addonInfo := [][]string{} |
There was a problem hiding this comment.
This variable only contains database information, or I don't see which condition are you talking about. I surely miss something here, could you point me where exactly please?
There was a problem hiding this comment.
🤦 my bad, I misread the code. You're right!
curzolapierre
force-pushed
the
fix/1054/addons-info_for_non_db_addon
branch
from
088c846
to
2dc2c1c
Compare
ipfaze
approved these changes
Mar 27, 2024
| return strings.EqualFold(s, addonInfo.AddonProvider.ID) | ||
| }) | ||
|
|
||
| dbInfo := [][]string{} |
There was a problem hiding this comment.
🤦 my bad, I misread the code. You're right!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1054