Fix #151: Destroy command is always run #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,13 +10,19 @@ import ( | |||
|
|
|||
| func Destroy(appName string) error { | |||
| var validationName string | |||
|
|
|||
| res, err := scalingo.AppsShow(appName) | |||
…_151 Conflicts: apps/destroy.go
Soulou
added a commit
that referenced
this pull request
Oct 19, 2015
Fix #151: Destroy command is always run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalingo destroywas always run, whatever appname you gave.I thought it would be better to check if the app is existing or not first.
So two requests instead of one, but the user has to type its app name again to confirm.
If he has to confirm an app that doesn't exists, it's even more bad than a 100ms request.