Skip to content

Commit

Permalink
SCALRCORE-27266 fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
DayS1eeper committed Jul 14, 2023
1 parent f204cea commit 59104db
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions scalr/resource_scalr_provider_configuration.go
Expand Up @@ -496,10 +496,10 @@ func resourceScalrProviderConfigurationRead(ctx context.Context, d *schema.Resou
if len(providerConfiguration.AwsTrustedEntityType) > 0 {
aws["trusted_entity_type"] = providerConfiguration.AwsTrustedEntityType
}
if len(providerConfiguration.AwsTrustedEntityType) > 0 {
if len(providerConfiguration.AwsRoleArn) > 0 {
aws["role_arn"] = providerConfiguration.AwsRoleArn
}
if len(providerConfiguration.AwsTrustedEntityType) > 0 {
if len(providerConfiguration.AwsExternalId) > 0 {
aws["external_id"] = providerConfiguration.AwsExternalId
}
if len(providerConfiguration.AwsWorkloadIdentityAudience) > 0 {
Expand Down
2 changes: 1 addition & 1 deletion scalr/resource_scalr_provider_configuration_test.go
Expand Up @@ -385,7 +385,7 @@ func TestAccProviderConfiguration_aws_oidc(t *testing.T) {
Config: testAccScalrProviderConfigurationAWSOidcUpdatedConfig(rNewName),
Check: resource.ComposeTestCheckFunc(
testAccCheckProviderConfigurationExists("scalr_provider_configuration.aws", &providerConfiguration),
resource.TestCheckResourceAttr("scalr_provider_configuration.aws", "name", rName),
resource.TestCheckResourceAttr("scalr_provider_configuration.aws", "name", rNewName),
resource.TestCheckResourceAttr("scalr_provider_configuration.aws", "export_shell_variables", "false"),
resource.TestCheckResourceAttr("scalr_provider_configuration.aws", "aws.#", "1"),
resource.TestCheckResourceAttr("scalr_provider_configuration.aws", "aws.0.role_arn", "arn:aws:iam::123456789012:role/scalr-oidc-role2"),
Expand Down

0 comments on commit 59104db

Please sign in to comment.