SCALRCORE-30839 remove 'secret-key' attr from 'scalr_webhook' datasource

Scalr · May 21, 2024 · fcc4b25 · fcc4b25
1 parent 6bf7671
commit fcc4b25
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Removed
+
+- `data.scalr_webhook`: drop attribute `secret_key` ([#313](https://github.com/Scalr/terraform-provider-scalr/pull/313))
+
 ### Added
 
 - `scalr_slack_integration`: new attribute `run_mode` ([#300](https://github.com/Scalr/terraform-provider-scalr/pull/300))

diff --git a/scalr/data_source_scalr_webhook.go b/scalr/data_source_scalr_webhook.go
@@ -91,13 +91,6 @@ func dataSourceScalrWebhook() *schema.Resource {
 				Computed:    true,
 			},
 
-			"secret_key": {
-				Description: "Secret key to sign the webhook payload.",
-				Type:        schema.TypeString,
-				Computed:    true,
-				Sensitive:   true,
-			},
-
 			"timeout": {
 				Description: "Endpoint timeout (in seconds).",
 				Type:        schema.TypeInt,

diff --git a/scalr/data_source_scalr_webhook_test.go b/scalr/data_source_scalr_webhook_test.go
@@ -50,8 +50,6 @@ func TestAccWebhookDataSource_basic(t *testing.T) {
 					// Attributes from related endpoint
 					resource.TestCheckResourceAttr(
 						"data.scalr_webhook.test", "url", "https://example.com/webhook"),
-					resource.TestCheckResourceAttrSet(
-						"data.scalr_webhook.test", "secret_key"),
 					resource.TestCheckResourceAttr(
 						"data.scalr_webhook.test", "timeout", "15"),
 					resource.TestCheckResourceAttr(
@@ -77,8 +75,6 @@ func TestAccWebhookDataSource_basic(t *testing.T) {
 						"data.scalr_webhook.test-new", "enabled", "false"),
 					resource.TestCheckResourceAttr(
 						"data.scalr_webhook.test-new", "url", "https://example.com/webhook"),
-					resource.TestCheckResourceAttrSet(
-						"data.scalr_webhook.test-new", "secret_key"),
 					resource.TestCheckResourceAttrSet(
 						"data.scalr_webhook.test-new", "timeout"),
 					resource.TestCheckResourceAttr(