SCALRCORE-28980 API > Policy Engine > Enforce policy group for all cu… #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrent and future environments
…rrent and future environments
DayS1eeper
approved these changes
Nov 20, 2023
petroprotsakh
requested changes
Nov 22, 2023
CHANGELOG.md
Outdated
| @@ -13,6 +13,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - `scalr_workspace`: new attribute `vcs-repo.trigger_patterns` ([#282](https://github.com/Scalr/terraform-provider-scalr/pull/282)) | |||
|
|
|||
| ### Changed | |||
There was a problem hiding this comment.
This should go to the 'Unreleased' section
scalr/resource_scalr_policy_group.go
Outdated
| if environmentID.(string) == "*" { | ||
| hasWildcard = true | ||
| } | ||
| if i != 0 && hasWildcard { |
There was a problem hiding this comment.
So this allows the list to be ["*", "env-xxx", "env-yyy"]?
I find the logic in this example more clear and correct.
There was a problem hiding this comment.
logic is correct, but changed it to be consistent with existing ones
…rrent and future environments
petroprotsakh
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrent and future environments
Changelog
Documentation
State