SCALRCORE-31246: Add RunScheduleRule resource #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyzohub
changed the title
lyzohub
force-pushed
the
SCALRCORE-31246
branch
3 times, most recently
from
27d303f
to
30e3ebe
Compare
| @@ -95,7 +95,7 @@ go mod edit -dropreplace github.com/scalr/go-scalr | |||
|
|
|||
| To update the go-scalr version: | |||
| ```sh | |||
| go get github.com/scalr/go-scalr@develop | |||
| go get github.com/scalr/go-scalr@master | |||
| Required: true, | ||
| }, | ||
| "schedule_mode": { | ||
| Description: "Mode of the scheduled run. (\"apply\", \"destroy\", \"refresh\")", |
There was a problem hiding this comment.
Suggested change
| Description: "Mode of the scheduled run. (\"apply\", \"destroy\", \"refresh\")", | |
| Description: "Mode of the scheduled run (\"apply\", \"destroy\", \"refresh\").", |
|
|
||
| // Get and check the workspace. | ||
| if workspaceID, ok := d.GetOk("workspace_id"); ok { | ||
| ws, err := scalrClient.Workspaces.ReadByID(ctx, workspaceID.(string)) |
There was a problem hiding this comment.
- Provider should not be doing this validation, it's an API responsibility
workspace_idis a required attribute, there is no need ind.GetOk()check
There was a problem hiding this comment.
- Provider should not be doing this validation, it's an API responsibility
@lyzohub The request is still there.
| id := d.Id() | ||
| if d.HasChange("schedule") || d.HasChange("schedule_mode") { | ||
| opts := scalr.RunScheduleRuleUpdateOptions{ | ||
| ID: id, |
There was a problem hiding this comment.
I would skip setting ID here to avoid confusion — keep only updatable attributes.
go.sum
Outdated
| github.com/scalr/go-scalr v0.0.0-20240620130121-1e510532b379 h1:MP3OOBJmXwNRM0vv2ocrio+Q06+zMF9CtfuPgaoO7Qk= | ||
| github.com/scalr/go-scalr v0.0.0-20240620130121-1e510532b379/go.mod h1:p34SHb25YRvbgft7SUjSDYESeoQhWzAlxGXId/BbaSE= | ||
| github.com/scalr/go-scalr v0.0.0-20240621143826-3720e9e9274f h1:qwB5rLRDA6alyD/Yg3ln57FBJNejRdHJd+9VaB9lRcE= | ||
| github.com/scalr/go-scalr v0.0.0-20240621143826-3720e9e9274f/go.mod h1:p34SHb25YRvbgft7SUjSDYESeoQhWzAlxGXId/BbaSE= |
There was a problem hiding this comment.
Run go mod tidy to clean up the old hashes.
lyzohub
force-pushed
the
SCALRCORE-31246
branch
2 times, most recently
from
038c4e4
to
79de1a4
Compare
petroprotsakh
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Documentation
State