Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted comments with multi lines is splitted by space instead of new line on Binary2Po #140

Closed
Darkmet98 opened this issue Aug 15, 2020 · 1 comment · Fixed by #141
Closed
Assignees
Milestone

Comments

@Darkmet98
Copy link
Contributor

Describe the bug
When you are reading a po from binary, when there is two or more lines on ExtractedComments, the result is splitted by spaces and not by new lines.
The error is in this function:
https://github.com/SceneGate/Yarhl/blob/develop/src/Yarhl.Media/Text/Binary2Po.cs#L210

To Reproduce
Steps to reproduce the behavior:

  1. Convert the po into binary
  2. Read the binary and converts the po
  3. See error

Expected behavior

speaker: Man's voice
header: {Init()}{Init2()}{ShowAvatar(char:11,version:1,0,1)}{PlayVoice(track:1,0,0,1)} 
tail: \\n{AutoEndVoice(65535)}{Wait()}"

instead of
speaker: Man's voice header: {Init()}{Init2()}{ShowAvatar(char:11,version:1,0,1)}{PlayVoice(track:1,0,0,1)} tail: \\n{AutoEndVoice(65535)}{Wait()}

@github-actions
Copy link

🎉 This issue has been resolved in version v3.1.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants